Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telemetry attributes not sent on token exchange request #149

Open
6 tasks done
jimmyjames opened this issue Feb 14, 2025 · 0 comments
Open
6 tasks done

telemetry attributes not sent on token exchange request #149

jimmyjames opened this issue Feb 14, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@jimmyjames
Copy link
Contributor

jimmyjames commented Feb 14, 2025

Checklist

  • I have looked into the README and have not found a suitable solution or answer.
  • I have looked into the documentation and have not found a suitable solution or answer.
  • I have searched the issues and have not found a suitable solution or answer.
  • I have upgraded to the latest version of OpenFGA and the issue still persists.
  • I have searched the Slack community and have not found a suitable solution or answer.
  • I agree to the terms within the OpenFGA Code of Conduct.

Description

When recording the counter for the credentials request, no attributes are sent.

Notice the empty attributes map sent on to record the metric: https://github.com/openfga/java-sdk/blob/main/src/main/java/dev/openfga/sdk/api/auth/OAuth2Client.java#L69

Attributes are created in HttpRequestAttempt, but they are not sent back to exchangeToken() and included in the call to record the counter.

Expectation

Any configured attributes, or the default attributes if not configured, should be sent with the credentials request.

Reproduction

Given the default telemetry configuration
When a credentials exchange request is executed
No attributes are sent with the fga-client.credentials.request counter metric

OpenFGA SDK version

0.8.0

OpenFGA version

any

SDK Configuration

no config

Logs

No response

References

No response

@jimmyjames jimmyjames added the bug Something isn't working label Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

1 participant