OEQ-1811 - fix(selectUser test): remove findElement

[edalex-yinzi]

Checklist

• the contributor license agreement is signed
• commit message follows commit guidelines
• tests are included
• screenshots are included showing significant UI changes
• documentation is changed or added

Description of change

I think the issue is when you input query in the user selector dialog, the result won't be rendered in the dom immediately, which causes the findElement to fail.

[edalex-yinzi]

1

[edalex-yinzi]

2

[edalex-yinzi]

3

[edalex-yinzi]

4

[edalex-yinzi]

5

[edalex-yinzi]

I didn't see the advanced Search selectUser test fail in 6 tries. I think it's good enough.

[edalex-ian]

Looks good thanks @edalex-yinzi . But...

I am slightly concerned that in your last three runs there were multiple instances of com.tle.webtests.test.searching.FavouritesPowerSearchIntegration failing where as I've not see that fail before. Considering 'Power Search' is the old name for Advanced Search are you sure this is not related?

[edalex-yinzi]

FavouritesPowerSearchIntegration actually is not a new one. I have seen this before both in GitHub and Gitlab.

[edalex-yinzi]

I can try to fix this in this MR.

[edalex-yinzi]

I think I just asked Penghai two days ago if this test is new, and he said no. Is this FavouritesPowerSearchIntegration test @PenghaiZhang ?

[PenghaiZhang]

FavouritesPowerSearchIntegration is an old test suite. It had been disabled for years until I brought it back recently. Yes it is a bit flaky.

[edalex-ian]

Ah! In that case we can probably merge this MR. That can be fixed elsewhere.