Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dockerfile & CI workflows to use Ubuntu 24.04 and Python 3.12 #397

Merged
merged 4 commits into from
Sep 4, 2024
Merged

Update Dockerfile & CI workflows to use Ubuntu 24.04 and Python 3.12 #397

merged 4 commits into from
Sep 4, 2024

Conversation

irtazaakram
Copy link
Member

@irtazaakram irtazaakram commented Aug 28, 2024 •
edited
Loading

This PR:

  1. Updates the Dockerfile to use Ubuntu 24.04 and Python 3.12.
  2. Replaces the deprecated docker-compose command with docker compose.
  3. Upgrades Ubuntu to 24.04 in the CI, Docker-publish, and PyPI-publish workflows.
  4. replaces pkg_resources with importlib.resources in cookiecutter

@farhan farhan mentioned this pull request Aug 29, 2024
Open
farhan
farhan requested changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@farhan farhan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some text change, rest all good
Good improvements overall 🌟

CHANGELOG.rst Outdated
0.13.0 - 2024-08-28
-------------------

* updated Dockerfile to use ubuntu 24.04 & python 3.12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following sounds concise to me:

  • upgraded to Ubuntu 24.04 and Python 3.12
  • replaced deprecated docker-compose command with docker compose

@irtazaakram irtazaakram merged commit fee0ef7 into master Sep 4, 2024
5 of 6 checks passed
@irtazaakram irtazaakram deleted the docker-compose-issue branch September 4, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farhan farhan farhan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Aximprovements Team
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move on from deprecated pkg_resources api Test xblock-sdk on Ubuntu 24.04
2 participants
@irtazaakram @farhan