[bug]: ModalPopup doesn't close on button click on mobile devices

[ihor-romaniuk]

Components: ModalPopup

Feedback summary

When you try to close an open ModalPopup modal for mobile devices, the closing does not occur, but 2 events are executed: close event and open event. Which makes it impossible to close the modal by clicking on the call button.
Note: this error does not occur for the desktop version.

2024-05-28.09.37.02.mov

Improvements

The modal should both open and close by clicking on the call button for desktop and mobile devices.

[brian-smith-tcril]

This seems to be an issue with how we're using react-focus-on, and is something others have run into as well theKashey/react-focus-on#33.

The react-focus-on readme has

[onClickOutside] - on click outside of "focus" area. (actually on any event "outside")

In our use case, this means onClickOutside is calling onClose when it receives a touchstart event, but the button doesn't do anything until it recieves a react click event, which happens afterwards during the same press.