-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Python 3.8 dropped and support for 3.12 added #471
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @CodeWithEmad! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently unmaintained. To get help with finding a technical reviewer, tag the community contributions project manager for this PR in a comment and let them know that your changes are ready for review:
Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
cc456ba
to
668888e
Compare
Hey @CodeWithEmad, thank you for this contribution! Let us know when it's ready for review. |
For sure, @itsjeyd. |
@CodeWithEmad Sounds good!
I'll forward this question to @feanil. |
We should continue to run the testing with both Python 3.11 and 3.12 but dropping 3.8 is totally fine across all |
7e6c865
to
9e0156e
Compare
@feanil I'm working on dropping Python 3.8 here, but there are a couple of blockers here:
which is still using Python 3.8, https://github.com/openedx/xblock-sdk/blob/1760448ebb073edba35be87d99f474d90d9421ac/Dockerfile#L19 https://github.com/openedx/edx-cookiecutters/actions/runs/10206678813/job/28240034237?pr=471 |
@CodeWithEmad I'll see if we can land the xblock-sdk issue first then we can update that as a part of the PR here. |
Issue will be fixed in openedx/xblock-sdk#397 |
Thanks, @farhan. I'll continue this in the coming weeks. |
Remove unnecessary branch specification for workflow_dispatch event
All of the functionalities in xblockutils is moved to xblock.utils inside XBlock pakcage
pkg_resources is available in python 3.12 only if setuptools is explicitly installed, which is not always the case. We fix that by replacing all usage of pkg_resources with importlib_resources.
* dev.stop: Stop the running container * dev.migrate: Run migrations in the container * dev.logs: View logs from the container * dev.exec: Execute to the dev container
9e0156e
to
b9e12fd
Compare
b9e12fd
to
a364d9b
Compare
This will update all the actions as follows:
Also, Python 3.12 added everywhere.
Close #460 #485