Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

feat: added option to delete downloaded videos from AccountFragment #1849

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

omerhabib26
Copy link
Contributor

@omerhabib26 omerhabib26 commented Feb 23, 2024

Description

LEARNER-9786

  • Allow users to delete downloaded videos from Accounts
DeleteDownloadedVideos.mp4

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 49 lines in your changes are missing coverage. Please review.

Project coverage is 1.07%. Comparing base (459dee2) to head (21c5339).

Files Patch % Lines
...c/main/java/org/edx/mobile/view/AccountFragment.kt 0.00% 32 Missing ⚠️
...in/java/org/edx/mobile/module/storage/Storage.java 0.00% 8 Missing ⚠️
...le/src/main/java/org/edx/mobile/util/FileUtil.java 0.00% 4 Missing ⚠️
...a/org/edx/mobile/module/db/impl/IDatabaseImpl.java 0.00% 3 Missing ⚠️
...module/storage/DeleteAllDownloadedVideosEvent.java 0.00% 1 Missing ⚠️
...bile/src/main/java/org/edx/mobile/view/Router.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             master   #1849      +/-   ##
===========================================
- Coverage      1.07%   1.07%   -0.01%     
  Complexity      137     137              
===========================================
  Files           538     539       +1     
  Lines         26339   26385      +46     
  Branches       3399    3400       +1     
===========================================
  Hits            284     284              
- Misses        26028   26074      +46     
  Partials         27      27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- Allow user to delete downloaded videos from Accounts
- Added relevant analytics
- Show a progress dialog for 2 sec while deleting
- Reset whole app external directory folder

fix: LEARNER-9786
Copy link
Contributor

@HamzaIsrar12 HamzaIsrar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏎️

@omerhabib26 omerhabib26 merged commit bd6299c into master Mar 1, 2024
4 checks passed
@omerhabib26 omerhabib26 deleted the omer/LEARNER-9786 branch March 1, 2024 19:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants