Skip to content
This repository has been archived by the owner on May 8, 2024. It is now read-only.

Commit

Permalink
feat(charts): remove mutually exclusive flags
Browse files Browse the repository at this point in the history
Remove mutually exclusive flags ie -
When ndm is installed using openebs-ndm chart then disable local
templates. When local pv is installed using localpv-provisioner
then disable local templates.

This will change the installation command from
```bash
helm install openebs openebs/openebs --namespace openebs --create-namespace \
--set localprovisioner.enabled=false \
--set ndm.enabled=false \
--set ndmOperator.enabled=false \
--set openebs-ndm.enabled=true \
--set legacy.enabled=false \
--set localpv-provisioner.enabled=true
```
to
```bash
helm install openebs openebs/openebs --namespace openebs --create-namespace \
--set legacy.enabled=false \
--set localpv-provisioner.enabled=true
--set openebs-ndm.enabled=true \
```

Signed-off-by: Shovan Maity <shovan.cse91@gmail.com>
  • Loading branch information
shovanmaity authored and kmova committed Aug 4, 2021
1 parent 3715a66 commit 0bdac0a
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 3 deletions.
2 changes: 1 addition & 1 deletion charts/openebs/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
apiVersion: v2
version: 2.11.3
version: 2.11.4
name: openebs
appVersion: 2.11.0
description: Containerized Storage for Containers
Expand Down
4 changes: 3 additions & 1 deletion charts/openebs/templates/cm-node-disk-manager.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
{{- if .Values.ndm.enabled }}
{{- $ndmValues := index .Values "openebs-ndm" }}
{{- if not $ndmValues.enabled }}
# This is the node-disk-manager related config.
# It can be used to customize the disks probes and filters
apiVersion: v1
Expand Down Expand Up @@ -42,5 +44,5 @@ data:
state: {{ .Values.ndm.filters.enablePathFilter }}
include: "{{ .Values.ndm.filters.includePaths }}"
exclude: "{{ .Values.ndm.filters.excludePaths }}"
---
{{- end }}
{{- end }}
3 changes: 3 additions & 0 deletions charts/openebs/templates/daemonset-ndm.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
{{- if .Values.ndm.enabled }}
{{- $ndmValues := index .Values "openebs-ndm" }}
{{- if not $ndmValues.enabled }}
apiVersion: apps/v1
kind: DaemonSet
metadata:
Expand Down Expand Up @@ -178,3 +180,4 @@ spec:
{{ toYaml .Values.ndm.tolerations | indent 8 }}
{{- end }}
{{- end }}
{{- end }}
3 changes: 3 additions & 0 deletions charts/openebs/templates/deployment-local-provisioner.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
{{- if .Values.localprovisioner.enabled }}
{{- $localpvprovisionerValues := index .Values "localpv-provisioner" }}
{{- if not $localpvprovisionerValues.enabled }}
apiVersion: apps/v1
kind: Deployment
metadata:
Expand Down Expand Up @@ -113,3 +115,4 @@ spec:
{{ toYaml .Values.localprovisioner.affinity | indent 8 }}
{{- end }}
{{- end }}
{{- end }}
4 changes: 3 additions & 1 deletion charts/openebs/templates/deployment-ndm-operator.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{{- if .Values.ndmOperator.enabled }}
---
{{- $ndmValues := index .Values "openebs-ndm" }}
{{- if not $ndmValues.enabled }}
apiVersion: apps/v1
kind: Deployment
metadata:
Expand Down Expand Up @@ -87,3 +88,4 @@ spec:
{{ toYaml .Values.ndmOperator.tolerations | indent 8 }}
{{- end }}
{{- end }}
{{- end }}

0 comments on commit 0bdac0a

Please sign in to comment.