fix(ci): fix inconsistencies

- use TAG instead of IMAGE_TAG in build.yml - update release.yml to remove set-output deprecated utility - update actions/checkout to v4 Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
openebs-archive · Nov 22, 2023 · d9695c5 · d9695c5
1 parent b631315
commit d9695c5
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 22 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -33,7 +33,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Shellcheck
         uses: reviewdog/action-shellcheck@v1
@@ -42,14 +42,13 @@ jobs:
           reporter: github-pr-review
           path: '.'
           pattern: '*.sh'
-          exclude: './vendor/*'
 
   upgrade:
     runs-on: ubuntu-latest
     needs: ['lint','upgrade-e2e']
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Set Image Org
         # sets the default IMAGE_ORG to openebs
@@ -83,7 +82,7 @@ jobs:
             ghcr.io/${{ env.IMAGE_ORG }}/upgrade
           tags: |
             type=raw,value=latest,enable=false
-            type=raw,value=${{ env.IMAGE_TAG }}
+            type=raw,value=${{ env.TAG }}
 
       - name: Print Tag info
         run: |
@@ -141,7 +140,7 @@ jobs:
     needs: ['lint', 'migration-e2e']
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Set Image Org
         # sets the default IMAGE_ORG to openebs
@@ -175,7 +174,7 @@ jobs:
             ghcr.io/${{ env.IMAGE_ORG }}/migrate
           tags: |
             type=raw,value=latest,enable=false
-            type=raw,value=${{ env.IMAGE_TAG }}
+            type=raw,value=${{ env.TAG }}
 
       - name: Print Tag info
         run: |
@@ -242,7 +241,7 @@ jobs:
       id: go
 
     - name: Check out code into the Go module directory
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
 
     - name: verify license
       run: make check-license 
@@ -262,7 +261,7 @@ jobs:
         kubernetes: [v1.27.3]
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Setup Minikube-Kubernetes
         uses: medyagh/setup-minikube@latest
@@ -297,7 +296,7 @@ jobs:
         engine: [cstor, jiva]
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Setup Minikube-Kubernetes
         uses: medyagh/setup-minikube@latest
@@ -349,7 +348,7 @@ jobs:
     needs: ['unit-tests']
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Set Image Org
         # sets the default IMAGE_ORG to openebs

diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml
@@ -32,7 +32,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Shellcheck
         uses: reviewdog/action-shellcheck@v1
@@ -41,14 +41,13 @@ jobs:
           reporter: github-pr-review
           path: '.'
           pattern: '*.sh'
-          exclude: './vendor/*'
 
   upgrade:
     runs-on: ubuntu-latest
     needs: ['lint']
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Set up QEMU
         uses: docker/setup-qemu-action@v2
@@ -76,7 +75,7 @@ jobs:
     needs: ['lint']
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Set up QEMU
         uses: docker/setup-qemu-action@v2
@@ -111,7 +110,7 @@ jobs:
       id: go
 
     - name: Check out code into the Go module directory
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
 
     - name: verify license
       run: make check-license 
@@ -131,7 +130,7 @@ jobs:
         kubernetes: [v1.27.3]
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Setup Minikube-Kubernetes
         uses: medyagh/setup-minikube@latest
@@ -162,7 +161,7 @@ jobs:
         engine: [cstor, jiva]
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Setup Minikube-Kubernetes
         uses: medyagh/setup-minikube@latest

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -25,7 +25,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Set Image Org
         # sets the default IMAGE_ORG to openebs
@@ -42,7 +42,7 @@ jobs:
       - name: Set Build Date
         id: date
         run: |
-          echo "::set-output name=DATE::$(date -u +'%Y-%m-%dT%H:%M:%S%Z')"
+          echo "DATE=$(date -u +'%Y-%m-%dT%H:%M:%S%Z')" >> $GITHUB_OUTPUT
 
       - name: Docker meta
         id: docker_meta
@@ -112,7 +112,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Set Image Org
         # sets the default IMAGE_ORG to openebs
@@ -129,7 +129,7 @@ jobs:
       - name: Set Build Date
         id: date
         run: |
-          echo "::set-output name=DATE::$(date -u +'%Y-%m-%dT%H:%M:%S%Z')"
+          echo "DATE=$(date -u +'%Y-%m-%dT%H:%M:%S%Z')" >> $GITHUB_OUTPUT
 
       - name: Docker meta
         id: docker_meta

diff --git a/.gitignore b/.gitignore
@@ -16,4 +16,4 @@
 # vendor/
 
 # IDE files
-.idea/
+**/.idea