Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(helm-chart): Disable NDM installation by default, test release with 2.8.3 #91

Merged
merged 2 commits into from
May 13, 2021
Merged

chore(helm-chart): Disable NDM installation by default, test release with 2.8.3 #91

merged 2 commits into from
May 13, 2021

Conversation

niladrih
Copy link
Member

Signed-off-by: Niladri Halder niladri.halder@mayadata.io

This PR does:

  1. Disables installation of NDM components by adding default localpv-provisioner options to values.yaml
  2. Disables installation of openebs-device StorageClass by adding default localpv-provisioner options to values.yaml
  3. Bumps dependency chart version to 2.8.1
  4. Bumps release chart version to 2.8.3. This is to test the release-chart action, as 2.8.2 release failed to create the chart .tgz resource

@niladrih
Add changes to disable NDM. Test release with 2.8.3
3fa7863 
Signed-off-by: Niladri Halder <niladri.halder@mayadata.io>
@niladrih
Add README.md changes
d682460 
Signed-off-by: Niladri Halder <niladri.halder@mayadata.io>
shubham14bajpai
shubham14bajpai approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@shubham14bajpai shubham14bajpai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

prateekpandey14
prateekpandey14 approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@prateekpandey14 prateekpandey14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@prateekpandey14 prateekpandey14 merged commit 2dbc25c into openebs-archive:master May 13, 2021
@niladrih niladrih deleted the no-ndm-in-jiva branch May 13, 2021 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prateekpandey14 prateekpandey14 prateekpandey14 approved these changes

@shubham14bajpai shubham14bajpai shubham14bajpai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niladrih @prateekpandey14 @shubham14bajpai