Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/cookie welcome dialog #145

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Conversation

Tjalling-dejong
Copy link
Collaborator

In this pull request I added code to set a cookie whenever a user presses the skip button. When a user reloads the page there is check if a skipTour cookie is set and if not the tour dialog is prompted to the user. The cookie expires in 30 days, I can change this to some other amount of time. Let me know if this is sufficient.

I have added functions to set and retrieve cookies in plain js. Unfortunately I could not use other vue plugings because of version conflicts.

Copy link

@github-actions github-actions bot temporarily deployed to pull request January 23, 2025 10:23 Inactive
Copy link

@github-actions github-actions bot temporarily deployed to pull request January 23, 2025 10:23 Inactive
Copy link

@github-actions github-actions bot temporarily deployed to pull request January 23, 2025 10:23 Inactive
@Tjalling-dejong Tjalling-dejong merged commit f84a72b into main Feb 4, 2025
6 checks passed
@Tjalling-dejong Tjalling-dejong deleted the feat/cookie-welcome-dialog branch February 4, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant