Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getCapabilities improvements #133

Merged
merged 6 commits into from
Jan 29, 2025
Merged

Conversation

sjoerdbeentjes
Copy link
Collaborator

No description provided.

Copy link

netlify bot commented Sep 6, 2024

Deploy Preview for deltares-viewer ready!

Name Link
🔨 Latest commit 6721c98
🔍 Latest deploy log https://app.netlify.com/sites/deltares-viewer/deploys/66db14f53785060008246072
😎 Deploy Preview https://deploy-preview-133--deltares-viewer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 6, 2024

Deploy Preview for rws-viewer ready!

Name Link
🔨 Latest commit 6721c98
🔍 Latest deploy log https://app.netlify.com/sites/rws-viewer/deploys/66db14f52256a500090c5f8d
😎 Deploy Preview https://deploy-preview-133--rws-viewer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sjoerdbeentjes sjoerdbeentjes marked this pull request as ready for review September 6, 2024 14:44
Copy link

@github-actions github-actions bot temporarily deployed to pull request January 24, 2025 09:37 Inactive
Copy link

Copy link

@github-actions github-actions bot temporarily deployed to pull request January 24, 2025 09:37 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 24, 2025 09:37 Inactive
@Tjalling-dejong
Copy link
Collaborator

There was an issue with downloading the CDDA data layer with the rws viewer. I figured out that the layer data also has a downloadUrl attribute that is not always populated. The CDDA dataset has a WMS and a WFS service. So the getCapabilities request will work for both service types. This will cause an error when trying to download because the viewer will attempt to download from the WMS url instead of the WFS url. I fixed this by adding a check that checks if there is a downloadUrl attribute in the layer data and use that url to download if it exists.

@luisrodriguezgalvez luisrodriguezgalvez merged commit f289718 into main Jan 29, 2025
6 checks passed
@luisrodriguezgalvez luisrodriguezgalvez deleted the fix-getcapabilities-type branch January 29, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants