-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax the torch version dependency #84
Conversation
Fixed upstream in vllm-project#5091
fixes RHOAIENG-8043 Co-authored-by: Chih-Chieh-Yang <chih.chieh.yang@ibm.com> Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com>
- get rid cuda-devel stage, use cuda 12.4 - add build flags - remove useless installs
add libsodium for tensorizer encryption --------- Signed-off-by: Prashant Gupta <prashantgupta@us.ibm.com> Co-authored-by: Daniele <36171005+dtrifiro@users.noreply.github.com>
Sync with upstream@v0.5.1-10-g16620f43
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fabiendupont The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @fabiendupont. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
9111485
to
fa813a2
Compare
Thanks. Commit amended. |
@fabiendupont this looks good but would you mind applying the same changes to |
The PyTorch project has released the patch version 2.3.1 with a number of fixes. This change relaxes the version in the requirements files for build and CUDA, in order to allow picking fixes, while not bumping to the next minor version. Signed-off-by: Fabien Dupont <fdupont@redhat.com>
fa813a2
to
4e9fcad
Compare
@dtrifiro, done. Sorry for the delay. |
@@ -2,6 +2,6 @@ | |||
-r requirements-common.txt | |||
|
|||
# Dependencies for x86_64 CPUs | |||
torch == 2.3.1+cpu; platform_machine != "ppc64le" | |||
torch >= 2.3.1+cpu, <2.4.0+cpu; platform_machine != "ppc64le" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks broken:
error in vllm setup command: 'install_requires' must be a string or list of strings containing valid project/version requirement specifiers; Local version label can only be used with `==` or `!=` operators
torch >= 2.3.1+cpu, <2.4.0+cpu; platform_machine != "ppc64le"
~~~~~~~~^
error: subprocess-exited-with-error
You can test this with env VLLM_CPU_DISABLE_AVX512=true VLLM_TARGET_DEVICE=cpu PIP_EXTRA_INDEX_URL=https://download.pytorch.org/whl/cpu pip install -e . -v
I think it's enough to specify two torch lines:
torch >= 2.3.1+cpu, <2.4.0+cpu; platform_machine != "ppc64le" | |
torch >= 2.3.1+cpu; platform_machine != "ppc64le" | |
torch < 2.4.0+cpu; platform_machine != "ppc64le" |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Torch is now set at 2.4.0, so this is not needed anymore. |
The PyTorch project has released the patch version 2.3.1 with a number of fixes. This change relaxes the version in the requirements files for build and CUDA, in order to allow picking fixes, while not bumping to the next minor version.