feat(tests): improved tests coverage unit/integration (#177)

* feat(tests): improved tests coverage unit/integration

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>

* fix(ci): missing folder in Dockerfile

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>

---------

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>

Dockerfile

@@ -14,7 +14,7 @@ RUN go mod download
 # Copy the go source
 COPY cmd/main.go cmd/main.go
 COPY api/ api/
-COPY internal/controller/ internal/controller/
+COPY internal/ internal/
 
 # Copy Makefile and build command requirements
 COPY config/ config/

api/v1alpha1/modelregistry_annotations_test.go

@@ -0,0 +1,64 @@
+package v1alpha1_test
+
+import (
+	"reflect"
+	"testing"
+
+	"github.com/opendatahub-io/model-registry-operator/api/v1alpha1"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+)
+
+func TestHandleAnnotations(t *testing.T) {
+	tests := []struct {
+		name            string
+		annotations     map[string]string
+		wantAnnotations map[string]string
+		mrRestImage     string
+		wantMrRestImage string
+	}{
+		{
+			name: "no handler annotations",
+			annotations: map[string]string{
+				"modelregistry.opendatahub.io/other-annotation": "true",
+			},
+			wantAnnotations: map[string]string{
+				"modelregistry.opendatahub.io/other-annotation": "true",
+			},
+			mrRestImage:     "test",
+			wantMrRestImage: "test",
+		},
+		{
+			name: "reset defaults",
+			annotations: map[string]string{
+				"modelregistry.opendatahub.io/reset-spec-defaults": "",
+			},
+			wantAnnotations: map[string]string{},
+			mrRestImage:     "test",
+			wantMrRestImage: "",
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			mr := &v1alpha1.ModelRegistry{
+				ObjectMeta: metav1.ObjectMeta{
+					Annotations: tt.annotations,
+				},
+				Spec: v1alpha1.ModelRegistrySpec{
+					Rest: v1alpha1.RestSpec{
+						Image: tt.mrRestImage,
+					},
+				},
+			}
+			mr.HandleAnnotations()
+
+			if !reflect.DeepEqual(mr.GetAnnotations(), tt.wantAnnotations) {
+				t.Errorf("HandleAnnotations() = %v, want %v", mr.GetAnnotations(), tt.wantAnnotations)
+			}
+
+			if mr.Spec.Rest.Image != tt.wantMrRestImage {
+				t.Errorf("HandleAnnotations() = %v, want %v", mr.Name, tt.wantMrRestImage)
+			}
+		})
+	}
+}

api/v1alpha1/modelregistry_webhook.go

@@ -19,18 +19,19 @@ package v1alpha1
 import (
 	"context"
 	"fmt"
+	"maps"
+	"slices"
+	"strings"
+
 	"github.com/opendatahub-io/model-registry-operator/internal/controller/config"
 	"k8s.io/apimachinery/pkg/api/errors"
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/apimachinery/pkg/util/validation/field"
-	"maps"
 	ctrl "sigs.k8s.io/controller-runtime"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 	logf "sigs.k8s.io/controller-runtime/pkg/log"
 	"sigs.k8s.io/controller-runtime/pkg/webhook"
 	"sigs.k8s.io/controller-runtime/pkg/webhook/admission"
-	"slices"
-	"strings"
 )
 
 // log is for logging in this package.