UPSTREAM: <carry>: Fixed workflow's ServiceAccountName

[hbelmiro]

Resolves: https://issues.redhat.com/browse/RHOAIENG-18533

Checklist:

• The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dsp-developers for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dsp-developers]

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 1 commits between d9ec34e3a0413201b529f808370bbc5d534f2a54...223937ee5835d9e49fba38c54edb9dfa10b8f313

[dsp-developers]

A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-129
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-129
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-129
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-129
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-129
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-129

[dsp-developers]

An OCP cluster where you are logged in as cluster admin is required.

The Data Science Pipelines team recommends testing this using the Data Science Pipelines Operator. Check here for more information on using the DSPO.

To use and deploy a DSP stack with these images (assuming the DSPO is deployed), first save the following YAML to a file named dspa.pr-129.yaml:

apiVersion: datasciencepipelinesapplications.opendatahub.io/v1alpha1
kind: DataSciencePipelinesApplication
metadata:
  name: pr-129
spec:
  dspVersion: v2
  apiServer:
    image: "quay.io/opendatahub/ds-pipelines-api-server:pr-129"
    argoDriverImage: "quay.io/opendatahub/ds-pipelines-driver:pr-129"
    argoLauncherImage: "quay.io/opendatahub/ds-pipelines-launcher:pr-129"
  persistenceAgent:
    image: "quay.io/opendatahub/ds-pipelines-persistenceagent:pr-129"
  scheduledWorkflow:
    image: "quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-129"
  mlmd:  
    deploy: true  # Optional component
    grpc:
      image: "quay.io/opendatahub/mlmd-grpc-server:latest"
    envoy:
      image: "registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2"
  mlpipelineUI:
    deploy: true  # Optional component 
    image: "quay.io/opendatahub/ds-pipelines-frontend:pr-129"
  objectStorage:
    minio:
      deploy: true
      image: 'quay.io/opendatahub/minio:RELEASE.2019-08-14T20-37-41Z-license-compliance'

Then run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines.git
cd data-science-pipelines/
git fetch origin pull/129/head
git checkout -b pullrequest 223937ee5835d9e49fba38c54edb9dfa10b8f313
oc apply -f dspa.pr-129.yaml

More instructions here on how to deploy and test a Data Science Pipelines Application.

[dsp-developers]

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 1 commits between d9ec34e3a0413201b529f808370bbc5d534f2a54...6bf5d290c988fdca717c6e8f6610348b927a7452

[dsp-developers]

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-129
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-129
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-129
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-129
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-129
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-129

[dsp-developers]

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 1 commits between d9ec34e3a0413201b529f808370bbc5d534f2a54...313f5d9e56c420a78b4a53c3adef070085fed4e7

[dsp-developers]

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 1 commits between d9ec34e3a0413201b529f808370bbc5d534f2a54...ae78d04c5ce30ddb1ad1fd8c0be8aaa1829ed3a6

[dsp-developers]

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-129
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-129
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-129
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-129
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-129
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-129

[dsp-developers]

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-129
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-129
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-129
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-129
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-129
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-129

[dsp-developers]

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting

commitchecker verson unknown
Validating 1 commits between d9ec34e3a0413201b529f808370bbc5d534f2a54...a5730912abf787e1d5d0d65bc05e3bd0708f605f

[jgarciao]

I've tested the fix following the instructions in the PR and pipeline schedules are working again. Also, I see no errors in the ds-pipeline-workflow-controller-dspa pod log related to missing service account.

Thanks for finding a fix so quick @hbelmiro & @HumairAK !

[hbelmiro]

/hold we decided to revert the previous changes for now.