STAC catalogue search #2
Conversation
datacosmos/const.py
Outdated
| DATACOSMOS_PRODUCTION_BASE_URL = "https://app.open-cosmos.com/api/data/v0" | ||
| DATACOSMOS_PRODUCTION_AUDIENCE = "https://beeapp.open-cosmos.com" | ||
| DATACOSMOS_TOKEN_URL = "https://opencosmos.eu.auth0.com/oauth/token" | ||
|
|
||
|
|
||
| class Satellites(Enum): |
There was a problem hiding this comment.
Will these read like something like from datacosmos.const import Satellites Satellites.SENTINEL_1A? I would have preferred something like from datacosmos.satellite import SENTINEL_1A and it would avoid creating a poorly-scoped const file which is going to be become very large and be a dumping ground for many things.
There was a problem hiding this comment.
Yeah we can do it that way, python Enums are not great so getting rid of them is no bad thing, it's just a shame to lose the informative type hint
There was a problem hiding this comment.
That's a fair point. Is there a way we can eat our cake and have it too, i.e. avoid the enum but keep nice type hints? Python equivalent of type Satellite string in Go?
There was a problem hiding this comment.
There is: https://docs.python.org/3/library/enum.html#enum.StrEnum
Unfortunately it was only introduced in python 3.11 and I don't think we want to restrict ourselves that much. We can update it in a few years!
|
This ideally should have been at least 4 MRs. Especially since this is a public facing SDK I expect there will be many comments, it will require quite a bit of discussion and changes, and it will get quite messy. |
No description provided.