add systemd-nspawn to implementations.md #1272
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a bit awkward really, since that nspawn isn't the WHOLE repo on GitHub unlike the others... Signed-off-by: Mingye Wang <arthur200126@gmail.com>
Artoria2e5
requested review from
AkihiroSuda,
crosbymichael,
cyphar,
dqminh,
giuseppe,
hqhq,
kolyshkin,
mrunalp,
thaJeztah,
tianon and
utam0k
as code owners
AkihiroSuda
approved these changes
Nov 29, 2024
|
AFAICS systemd-nspawn does not implement this spec. |
Therefore this should be closed (unless I'm missing something). |
Implements: https://github.com/systemd/systemd/blob/main/src/nspawn/nspawn-oci.c |
|
My bad, indeed, |
kolyshkin
approved these changes
Jan 16, 2025
ping @Artoria2e5 |
|
ping @Artoria2e5 |
|
It reads a bundle (config.json, rootfs, etc.) but it doesn't seem to implement any of the subcommands (like features, list, etc.) and IIRC it's not a full spec or at the very least is an old spec what it implements (I think the former, not the full spec, of some old version of the spec). |
Artoria2e5
commented
Feb 13, 2025
Signed-off-by: Mingye Wang <arthur200126@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a bit awkward really, since that nspawn isn't the WHOLE repo on GitHub unlike the others...