Merge pull request #4157 from kinvolk/rata/idmap-errormsg

libct: Improve error msg when idmap is not supported
opencontainers · Dec 29, 2023 · 35988ab · 35988ab
2 parents c48c428 + a7c3e07
commit 35988ab
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/libcontainer/mount_linux.go b/libcontainer/mount_linux.go
@@ -258,7 +258,12 @@ func mountFd(nsHandles *userns.Handles, m *configs.Mount) (*mountSource, error)
 			Attr_set:  unix.MOUNT_ATTR_IDMAP,
 			Userns_fd: uint64(usernsFile.Fd()),
 		}); err != nil {
-			return nil, fmt.Errorf("failed to set MOUNT_ATTR_IDMAP on %s: %w", m.Source, err)
+			extraMsg := ""
+			if err == unix.EINVAL {
+				extraMsg = " (maybe the filesystem used doesn't support idmap mounts on this kernel?)"
+			}
+
+			return nil, fmt.Errorf("failed to set MOUNT_ATTR_IDMAP on %s: %w%s", m.Source, err, extraMsg)
 		}
 	} else {
 		var err error