Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test to retain inner packet TTL if inner packet TTL=1 #3521

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vishnureddybadveli
Copy link
Contributor

Added the missed functionality of retaining inner TTL.

Added the missed functionality of retaining inner TTL
@OpenConfigBot
Copy link

OpenConfigBot commented Oct 17, 2024

Pull Request Functional Test Report for #3521 / 8f58ae1

No tests identified for validation.

Help

@vishnureddybadveli vishnureddybadveli self-assigned this Oct 17, 2024
@coveralls
Copy link

coveralls commented Oct 17, 2024

Pull Request Test Coverage Report for Build 11388295421

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.268%

Totals Coverage Status
Change from base Build 11376427199: 0.0%
Covered Lines: 1983
Relevant Lines: 3588

💛 - Coveralls

@vishnureddybadveli
Copy link
Contributor Author

As per vendors there is support to retain inner packet TTL, test case does not describe how exactly it is done byvendor implementation. Test case mentions that match should check for inner packet TTL == 1 but retaining inner TTL is vendor implementation.

Addressing the review comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants