Rt 1.54 bgp_override_as_path_split_horizon_test.go #3432

cprabha · 2024-09-17T00:20:52Z

Hi,

This is initial commit for RT-1.54

OpenConfigBot · 2024-09-17T00:21:13Z

Pull Request Functional Test Report for #3432 / `694439b`

Virtual Devices

Device	Test Documentation	Job	Raw Log
Arista cEOS	RT-1.54: BGP Override AS-path split-horizon	071c16f9	Log
Cisco 8000E	RT-1.54: BGP Override AS-path split-horizon	f9455ba0	Log
Cisco XRd	RT-1.54: BGP Override AS-path split-horizon	ebe4e1e9	Log
Juniper ncPTX	RT-1.54: BGP Override AS-path split-horizon	8982bdd0	Log
Nokia SR Linux	RT-1.54: BGP Override AS-path split-horizon	8b40865f	Log
Openconfig Lemming	RT-1.54: BGP Override AS-path split-horizon	696015af	Log

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		RT-1.54: BGP Override AS-path split-horizon
Cisco 8808		RT-1.54: BGP Override AS-path split-horizon
Juniper PTX10008		RT-1.54: BGP Override AS-path split-horizon
Nokia 7250 IXR-10e		RT-1.54: BGP Override AS-path split-horizon

Help

coveralls · 2024-09-17T00:23:20Z

Pull Request Test Coverage Report for Build 11352956716

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.268%

Totals
Change from base Build 11337664428:	0.0%
Covered Lines:	1983
Relevant Lines:	3588

💛 - Coveralls

…into RT-1.54

dplore · 2024-09-18T00:35:43Z

/fptest virtual

dplore · 2024-10-15T01:18:19Z

/fptest virtual

dplore · 2024-10-15T01:18:54Z

@cprabha please move this test to the feature/bgp/otg_tests/bgp_override_as_path_split_horizon_test folder.

(The experimental folder is now deprecated)

dplore · 2024-10-15T01:22:26Z

@cprabha this test does not pass on cptx. See logs from the cptx test mentioned in this PR request.

Here is a snippet from those logs. Please investigate:

Step #1 - "fp-presubmit":     bgp_override_as_path_split_horizon_test.go:288: 
Step #1 - "fp-presubmit":         *** Starting protocols on otg...
Step #1 - "fp-presubmit":         
Step #1 - "fp-presubmit":         
Step #1 - "fp-presubmit":     bgp_override_as_path_split_horizon_test.go:468: Validate session state and capabilities received on DUT using telemetry.
Step #1 - "fp-presubmit":     bgp_override_as_path_split_horizon_test.go:469: Verifying BGP state.
Step #1 - "fp-presubmit": I0918 01:07:53.410345   39650 deviations.go:104] Did not match any platform_exception [platform:{vendor:NOKIA}  deviations:{explicit_interface_in_default_vrf:true  interface_enabled:true} platform:{vendor:ARISTA}  deviations:{route_policy_under_afi_unsupported:true  omit_l2_mtu:true  interface_enabled:true  default_network_instance:"default"  bgp_set_med_requires_equal_ospf_set_metric:true}], returning default values
Step #1 - "fp-presubmit":     bgp_override_as_path_split_horizon_test.go:469: Waiting for BGP neighbor to establish...
Step #1 - "fp-presubmit":     bgp_override_as_path_split_horizon_test.go:469: BGP adjacency for 192.0.2.2: ESTABLISHED
Step #1 - "fp-presubmit":     bgp_override_as_path_split_horizon_test.go:469: Waiting for BGP neighbor to establish...
Step #1 - "fp-presubmit":     bgp_override_as_path_split_horizon_test.go:469: BGP adjacency for 192.0.2.6: ESTABLISHED
Step #1 - "fp-presubmit":     bgp_override_as_path_split_horizon_test.go:247: Verifying BGP capabilities
Step #1 - "fp-presubmit": I0918 01:07:55.466682   39650 deviations.go:104] Did not match any platform_exception [platform:{vendor:NOKIA}  deviations:{explicit_interface_in_default_vrf:true  interface_enabled:true} platform:{vendor:ARISTA}  deviations:{route_policy_under_afi_unsupported:true  omit_l2_mtu:true  interface_enabled:true  default_network_instance:"default"  bgp_set_med_requires_equal_ospf_set_metric:true}], returning default values
Step #1 - "fp-presubmit":     bgp_override_as_path_split_horizon_test.go:472: Verify that the DUT accepts the route.
Step #1 - "fp-presubmit": I0918 01:07:59.505229   39650 deviations.go:104] Did not match any platform_exception [platform:{vendor:NOKIA}  deviations:{explicit_interface_in_default_vrf:true  interface_enabled:true} platform:{vendor:ARISTA}  deviations:{route_policy_under_afi_unsupported:true  omit_l2_mtu:true  interface_enabled:true  default_network_instance:"default"  bgp_set_med_requires_equal_ospf_set_metric:true}], returning default values
Step #1 - "fp-presubmit":     bgp_override_as_path_split_horizon_test.go:473: Installed prefixes mismatch: got 0, want 1
Step #1 - "fp-presubmit": I0918 01:08:03.542736   39650 deviations.go:104] Did not match any platform_exception [platform:{vendor:NOKIA}  deviations:{explicit_interface_in_default_vrf:true  interface_enabled:true} platform:{vendor:ARISTA}  deviations:{route_policy_under_afi_unsupported:true  omit_l2_mtu:true  interface_enabled:true  default_network_instance:"default"  bgp_set_med_requires_equal_ospf_set_metric:true}], returning default values
Step #1 - "fp-presubmit":     bgp_override_as_path_split_horizon_test.go:474: Sent prefixes mismatch: got 0, want 1
Step #1 - "fp-presubmit":     bgp_override_as_path_split_horizon_test.go:476: Verify that the ATE Port2 receives the route.
Step #1 - "fp-presubmit": --- FAIL: TestBGPOverrideASPathSplitHorizon (999.62s)
Step #1 - "fp-presubmit":     --- PASS: TestBGPOverrideASPathSplitHorizon/Configure_DUT_interfaces (17.08s)
Step #1 - "fp-presubmit":     --- PASS: TestBGPOverrideASPathSplitHorizon/Configure_DEFAULT_network_instance (2.71s)
Step #1 - "fp-presubmit":     --- PASS: TestBGPOverrideASPathSplitHorizon/Configure_BGP_Neighbors (7.41s)
Step #1 - "fp-presubmit":     --- PASS: TestBGPOverrideASPathSplitHorizon/Verify_port_status_on_DUT (6.04s)
Step #1 - "fp-presubmit":     --- PASS: TestBGPOverrideASPathSplitHorizon/Verify_BGP_telemetry (6.09s)
Step #1 - "fp-presubmit":     --- PASS: TestBGPOverrideASPathSplitHorizon/_Baseline_Test_No_allow-own-in (134.46s)
Step #1 - "fp-presubmit":     --- PASS: TestBGPOverrideASPathSplitHorizon/_Test_allow-own-as_1 (138.50s)
Step #1 - "fp-presubmit":     --- PASS: TestBGPOverrideASPathSplitHorizon/Re-advertise_the_prefix_from_the_ATE_with_1_Occurrence:_65500_dutLocalAS1_65499 (74.60s)
Step #1 - "fp-presubmit":     --- FAIL: TestBGPOverrideASPathSplitHorizon/Re-advertise_the_prefix_from_the_ATE_with_3_Occurrences:_dutLocalAS1,_dutLocalAS1,_dutLocalAS1,_65499 (130.29s)
Step #1 - "fp-presubmit":     --- PASS: TestBGPOverrideASPathSplitHorizon/Re-advertise_the_prefix_from_the_ATE_with_4_Occurrences:_dutLocalAS1,_dutLocalAS1,_dutLocalAS1,_dutLocalAS1,_65499_(Should_be_rejected) (134.34s)
Step #1 - "fp-presubmit":     --- PASS: TestBGPOverrideASPathSplitHorizon/_Test_allow-own-as_3 (343.37s)
Step #1 - "fp-presubmit":     --- PASS: TestBGPOverrideASPathSplitHorizon/Re-advertise_the_prefix_from_the_ATE_with_1_Occurrence:_65500,_dutLocalAS1,_65499 (74.35s)
Step #1 - "fp-presubmit":     --- PASS: TestBGPOverrideASPathSplitHorizon/Re-advertise_the_prefix_from_the_ATE_with_3_Occurrences:_dutLocalAS1,_dutLocalAS1,_dutLocalAS1,_65499#01 (70.31s)
Step #1 - "fp-presubmit":     --- FAIL: TestBGPOverrideASPathSplitHorizon/Re-advertise_the_prefix_from_the_ATE_with_4_Occurrences:_dutLocalAS1,_dutLocalAS1,_dutLocalAS1,_dutLocalAS1,_65499_(Should_be_accepted) (134.32s)
Step #1 - "fp-presubmit":     --- PASS: TestBGPOverrideASPathSplitHorizon/_Test_allow-own-as_4 (283.08s)
Step #1 - "fp-presubmit": FAIL
Step #1 - "fp-presubmit": I0918 01:09:07.623301   39650 core.go:212] core file check found cores:
Step #1 - "fp-presubmit": 
Step #1 - "fp-presubmit": Delta Core Files by DUT: 
Step #1 - "fp-presubmit": DUT: dut
Step #1 - "fp-presubmit": *** PROPERTY: validator.core.end -> 
Step #1 - "fp-presubmit": Delta Core Files by DUT: 
Step #1 - "fp-presubmit": DUT: dut
Step #1 - "fp-presubmit": 
Step #1 - "fp-presubmit": *** Releasing the testbed...
Step #1 - "fp-presubmit": 
Step #1 - "fp-presubmit": *** PROPERTY: time.begin -> 1726620738
Step #1 - "fp-presubmit": *** PROPERTY: time.end -> 1726621747
Step #1 - "fp-presubmit": FAIL	github.com/openconfig/featureprofiles/feature/experimental/bgp/otg_tests/bgp_override_as_path_split_horizon_test	1009.417s

cprabha · 2024-10-15T02:26:06Z

@cprabha please move this test to the feature/bgp/otg_tests/bgp_override_as_path_split_horizon_test folder.

(The experimental folder is now deprecated)

@dplore moved files to main bgp folder.

cprabha · 2024-10-15T02:45:08Z

Step #1 - "fp

@dplore I will check this and update it.

cprabha · 2024-10-15T19:27:38Z

@cprabha this test does not pass on cptx. See logs from the cptx test mentioned in this PR request.

Here is a snippet from those logs. Please investigate:

Step #1 - "fp-presubmit":     bgp_override_as_path_split_horizon_test.go:288: 
Step #1 - "fp-presubmit":         *** Starting protocols on otg...
Step #1 - "fp-presubmit":         
Step #1 - "fp-presubmit":         
Step #1 - "fp-presubmit":     bgp_override_as_path_split_horizon_test.go:468: Validate session state and capabilities received on DUT using telemetry.
Step #1 - "fp-presubmit":     bgp_override_as_path_split_horizon_test.go:469: Verifying BGP state.
Step #1 - "fp-presubmit": I0918 01:07:53.410345   39650 deviations.go:104] Did not match any platform_exception [platform:{vendor:NOKIA}  deviations:{explicit_interface_in_default_vrf:true  interface_enabled:true} platform:{vendor:ARISTA}  deviations:{route_policy_under_afi_unsupported:true  omit_l2_mtu:true  interface_enabled:true  default_network_instance:"default"  bgp_set_med_requires_equal_ospf_set_metric:true}], returning default values
Step #1 - "fp-presubmit":     bgp_override_as_path_split_horizon_test.go:469: Waiting for BGP neighbor to establish...
Step #1 - "fp-presubmit":     bgp_override_as_path_split_horizon_test.go:469: BGP adjacency for 192.0.2.2: ESTABLISHED
Step #1 - "fp-presubmit":     bgp_override_as_path_split_horizon_test.go:469: Waiting for BGP neighbor to establish...
Step #1 - "fp-presubmit":     bgp_override_as_path_split_horizon_test.go:469: BGP adjacency for 192.0.2.6: ESTABLISHED
Step #1 - "fp-presubmit":     bgp_override_as_path_split_horizon_test.go:247: Verifying BGP capabilities
Step #1 - "fp-presubmit": I0918 01:07:55.466682   39650 deviations.go:104] Did not match any platform_exception [platform:{vendor:NOKIA}  deviations:{explicit_interface_in_default_vrf:true  interface_enabled:true} platform:{vendor:ARISTA}  deviations:{route_policy_under_afi_unsupported:true  omit_l2_mtu:true  interface_enabled:true  default_network_instance:"default"  bgp_set_med_requires_equal_ospf_set_metric:true}], returning default values
Step #1 - "fp-presubmit":     bgp_override_as_path_split_horizon_test.go:472: Verify that the DUT accepts the route.
Step #1 - "fp-presubmit": I0918 01:07:59.505229   39650 deviations.go:104] Did not match any platform_exception [platform:{vendor:NOKIA}  deviations:{explicit_interface_in_default_vrf:true  interface_enabled:true} platform:{vendor:ARISTA}  deviations:{route_policy_under_afi_unsupported:true  omit_l2_mtu:true  interface_enabled:true  default_network_instance:"default"  bgp_set_med_requires_equal_ospf_set_metric:true}], returning default values
Step #1 - "fp-presubmit":     bgp_override_as_path_split_horizon_test.go:473: Installed prefixes mismatch: got 0, want 1
Step #1 - "fp-presubmit": I0918 01:08:03.542736   39650 deviations.go:104] Did not match any platform_exception [platform:{vendor:NOKIA}  deviations:{explicit_interface_in_default_vrf:true  interface_enabled:true} platform:{vendor:ARISTA}  deviations:{route_policy_under_afi_unsupported:true  omit_l2_mtu:true  interface_enabled:true  default_network_instance:"default"  bgp_set_med_requires_equal_ospf_set_metric:true}], returning default values
Step #1 - "fp-presubmit":     bgp_override_as_path_split_horizon_test.go:474: Sent prefixes mismatch: got 0, want 1
Step #1 - "fp-presubmit":     bgp_override_as_path_split_horizon_test.go:476: Verify that the ATE Port2 receives the route.
Step #1 - "fp-presubmit": --- FAIL: TestBGPOverrideASPathSplitHorizon (999.62s)
Step #1 - "fp-presubmit":     --- PASS: TestBGPOverrideASPathSplitHorizon/Configure_DUT_interfaces (17.08s)
Step #1 - "fp-presubmit":     --- PASS: TestBGPOverrideASPathSplitHorizon/Configure_DEFAULT_network_instance (2.71s)
Step #1 - "fp-presubmit":     --- PASS: TestBGPOverrideASPathSplitHorizon/Configure_BGP_Neighbors (7.41s)
Step #1 - "fp-presubmit":     --- PASS: TestBGPOverrideASPathSplitHorizon/Verify_port_status_on_DUT (6.04s)
Step #1 - "fp-presubmit":     --- PASS: TestBGPOverrideASPathSplitHorizon/Verify_BGP_telemetry (6.09s)
Step #1 - "fp-presubmit":     --- PASS: TestBGPOverrideASPathSplitHorizon/_Baseline_Test_No_allow-own-in (134.46s)
Step #1 - "fp-presubmit":     --- PASS: TestBGPOverrideASPathSplitHorizon/_Test_allow-own-as_1 (138.50s)
Step #1 - "fp-presubmit":     --- PASS: TestBGPOverrideASPathSplitHorizon/Re-advertise_the_prefix_from_the_ATE_with_1_Occurrence:_65500_dutLocalAS1_65499 (74.60s)
Step #1 - "fp-presubmit":     --- FAIL: TestBGPOverrideASPathSplitHorizon/Re-advertise_the_prefix_from_the_ATE_with_3_Occurrences:_dutLocalAS1,_dutLocalAS1,_dutLocalAS1,_65499 (130.29s)
Step #1 - "fp-presubmit":     --- PASS: TestBGPOverrideASPathSplitHorizon/Re-advertise_the_prefix_from_the_ATE_with_4_Occurrences:_dutLocalAS1,_dutLocalAS1,_dutLocalAS1,_dutLocalAS1,_65499_(Should_be_rejected) (134.34s)
Step #1 - "fp-presubmit":     --- PASS: TestBGPOverrideASPathSplitHorizon/_Test_allow-own-as_3 (343.37s)
Step #1 - "fp-presubmit":     --- PASS: TestBGPOverrideASPathSplitHorizon/Re-advertise_the_prefix_from_the_ATE_with_1_Occurrence:_65500,_dutLocalAS1,_65499 (74.35s)
Step #1 - "fp-presubmit":     --- PASS: TestBGPOverrideASPathSplitHorizon/Re-advertise_the_prefix_from_the_ATE_with_3_Occurrences:_dutLocalAS1,_dutLocalAS1,_dutLocalAS1,_65499#01 (70.31s)
Step #1 - "fp-presubmit":     --- FAIL: TestBGPOverrideASPathSplitHorizon/Re-advertise_the_prefix_from_the_ATE_with_4_Occurrences:_dutLocalAS1,_dutLocalAS1,_dutLocalAS1,_dutLocalAS1,_65499_(Should_be_accepted) (134.32s)
Step #1 - "fp-presubmit":     --- PASS: TestBGPOverrideASPathSplitHorizon/_Test_allow-own-as_4 (283.08s)
Step #1 - "fp-presubmit": FAIL
Step #1 - "fp-presubmit": I0918 01:09:07.623301   39650 core.go:212] core file check found cores:
Step #1 - "fp-presubmit": 
Step #1 - "fp-presubmit": Delta Core Files by DUT: 
Step #1 - "fp-presubmit": DUT: dut
Step #1 - "fp-presubmit": *** PROPERTY: validator.core.end -> 
Step #1 - "fp-presubmit": Delta Core Files by DUT: 
Step #1 - "fp-presubmit": DUT: dut
Step #1 - "fp-presubmit": 
Step #1 - "fp-presubmit": *** Releasing the testbed...
Step #1 - "fp-presubmit": 
Step #1 - "fp-presubmit": *** PROPERTY: time.begin -> 1726620738
Step #1 - "fp-presubmit": *** PROPERTY: time.end -> 1726621747
Step #1 - "fp-presubmit": FAIL	github.com/openconfig/featureprofiles/feature/experimental/bgp/otg_tests/bgp_override_as_path_split_horizon_test	1009.417s

This is fixed, we need to add deviation . please could you re run and check.

dplore · 2024-10-15T20:11:03Z

/fptest virtual

cprabha added 2 commits September 4, 2024 14:33

Initial commit for RT-1.54

8c157d4

Updated

7d3ffda

cprabha requested a review from a team as a code owner September 17, 2024 00:20

Merge branch 'main' into RT-1.54

5619646

cprabha added 2 commits September 16, 2024 17:25

updated metadata.textproto

0624eb2

Merge branch 'RT-1.54' of https://github.com/cprabha/featureprofiles …

536bfac

…into RT-1.54

cprabha added the juniper-pr label Sep 17, 2024

hnnagashree assigned sachendras and dplore and unassigned sachendras Oct 3, 2024

Moving files out of experimental folder

ff5f6c1

cprabha requested a review from dplore as a code owner October 15, 2024 02:25

Merge branch 'main' into RT-1.54

f42a610

cprabha added 2 commits October 14, 2024 19:38

moving files

489f7a5

fixing folder issue

1f0ab5f

Added deviation

694439b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rt 1.54 bgp_override_as_path_split_horizon_test.go #3432

Rt 1.54 bgp_override_as_path_split_horizon_test.go #3432

cprabha commented Sep 17, 2024

OpenConfigBot commented Sep 17, 2024 •

edited

Loading

coveralls commented Sep 17, 2024 •

edited

Loading

dplore commented Sep 18, 2024

dplore commented Oct 15, 2024

dplore commented Oct 15, 2024

dplore commented Oct 15, 2024

cprabha commented Oct 15, 2024

cprabha commented Oct 15, 2024

cprabha commented Oct 15, 2024

dplore commented Oct 15, 2024

Rt 1.54 bgp_override_as_path_split_horizon_test.go #3432

Are you sure you want to change the base?

Rt 1.54 bgp_override_as_path_split_horizon_test.go #3432

Conversation

cprabha commented Sep 17, 2024

OpenConfigBot commented Sep 17, 2024 • edited Loading

Pull Request Functional Test Report for #3432 / 694439b

Virtual Devices

Hardware Devices

coveralls commented Sep 17, 2024 • edited Loading

Pull Request Test Coverage Report for Build 11352956716

Details

💛 - Coveralls

dplore commented Sep 18, 2024

dplore commented Oct 15, 2024

dplore commented Oct 15, 2024

dplore commented Oct 15, 2024

cprabha commented Oct 15, 2024

cprabha commented Oct 15, 2024

cprabha commented Oct 15, 2024

dplore commented Oct 15, 2024

OpenConfigBot commented Sep 17, 2024 •

edited

Loading

Pull Request Functional Test Report for #3432 / `694439b`

coveralls commented Sep 17, 2024 •

edited

Loading