Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable mTLS support for gNMI exporter. #15

Merged
merged 11 commits into from
Oct 7, 2024
Merged

Enable mTLS support for gNMI exporter. #15

merged 11 commits into from
Oct 7, 2024

Conversation

LarsxGitHub
Copy link
Contributor

This CL extends the gNMI exporter with configuration support for mTLS.

MISC:

  • added exemplary credentials to testdata. None of these credentials are used for anything besides testing.
  • also fixes a previously broken test for gnmi/gnmi.go.

@robshakir robshakir self-requested a review July 23, 2024 15:52
@robshakir
Copy link
Contributor

@LarsxGitHub -- can you add the config to run the GitHub actions workflows here? It looks like go.yml is in the wrong place, so there are no checks running that validate the build.

gnmi/config.go Outdated Show resolved Hide resolved
gnmi/gnmi_test.go Outdated Show resolved Hide resolved
gnmi/security.go Outdated Show resolved Hide resolved
gnmi/security.go Show resolved Hide resolved
@robshakir
Copy link
Contributor

#17 will need to be submitted before this PR, since I made changes to the repo to require the CI checks pass before we merge.

@coveralls
Copy link

coveralls commented Oct 7, 2024

Pull Request Test Coverage Report for Build 11218708668

Details

  • 70 of 93 (75.27%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.4%) to 77.474%

Changes Missing Coverage Covered Lines Changed/Added Lines %
gnmi/gnmi.go 3 4 75.0%
gnmi/security.go 67 77 87.01%
cmd/clio.go 0 12 0.0%
Files with Coverage Reduction New Missed Lines %
gnmi/gnmi.go 1 82.77%
Totals Coverage Status
Change from base Build 11217690156: 0.4%
Covered Lines: 368
Relevant Lines: 475

💛 - Coveralls

@LarsxGitHub LarsxGitHub merged commit bd01d73 into main Oct 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants