Protect global n with a mutex.

openconfig · Jul 29, 2024 · 83b3ef0 · 83b3ef0
1 parent d6c4761
commit 83b3ef0
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/gnmi/gnmi_test.go b/gnmi/gnmi_test.go
@@ -16,6 +16,7 @@ package gnmi
 
 import (
 	"context"
+	"sync"
 	"testing"
 	"time"
 
@@ -73,7 +74,10 @@ func TestHandleMetrics(t *testing.T) {
 			}
 
 			n := &gpb.Notification{}
+			var nMu sync.Mutex
 			updateFn := func(notif *gpb.Notification) error {
+				nMu.Lock()
+				defer nMu.Unlock()
 				n.Update = append(n.Update, notif.Update...)
 				return nil
 			}
@@ -86,6 +90,8 @@ func TestHandleMetrics(t *testing.T) {
 			close(g.metricCh)
 
 			time.Sleep(time.Second)
+			nMu.Lock()
+			defer nMu.Unlock()
 			if len(n.Update) != tc.wantCnt {
 				t.Errorf("missing updates: want %d got %d", tc.wantCnt, len(n.Update))
 			}