Implement editor locking so only one person can edit a recording a time #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesUoM
commented
Jul 12, 2023
| @@ -28,7 +29,10 @@ const Body: React.FC = () => { | |||
| ) | |||
| } else if (isEnd) { | |||
| return ( | |||
| <TheEnd /> | |||
| <div> | |||
| <Lock /> | |||
There was a problem hiding this comment.
Lock component appears here so that any lock can be freed on discarding of edits
|
This pull request is deployed at test.editor.opencast.org/1102/2023-07-12_12-28-27/ . |
Arnei
approved these changes
Jul 24, 2023
github-actions
bot
added
the
status:conflicts
|
This pull request has conflicts ☹ |
|
@JamesUoM Could you resolve the conflicts so we can merge this? |
# Conflicts: # src/redux/videoSlice.ts # src/util/utilityFunctions.ts
github-actions
bot
removed
the
status:conflicts
JamesUoM
force-pushed
the
f/editor-lock
branch
from
2ffcc37
to
9a1d8ce
Compare
|
This pull request is deployed at test.editor.opencast.org/1102/2023-10-04_14-00-32/ . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works with the corresponding feature in Opencast [1] when it is enabled in the editor service config. When locking is enabled only one person can edit a video at time. This is for the use case where multiple people have access to a video and may have been notified it is ready for editing.
[1] opencast/opencast#4658
UoM: MAT-468