Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add callback url for integration (#1084) #1100

Merged
merged 4 commits into from
Sep 21, 2023
Merged

Add callback url for integration (#1084) #1100

merged 4 commits into from
Sep 21, 2023

Conversation

dennis531
Copy link
Collaborator

After finishing the editing, the user can now navigate back to the calling system using a button. For this, the integrating system can pass a callbackUrl url parameter to provide a return link. In the editor settings, the prefixes of the allowed callback urls must be provided in the allowedCallbackPrefixes option to prevent malicious callback urls.

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

This pull request is deployed at test.editor.opencast.org/1100/2023-07-05_13-14-54/ .
It might take a few minutes for it to become available.

@dennis531 dennis531 added the type:feature A new feature or feature request label Jul 5, 2023
lkiesow
lkiesow reviewed Jul 5, 2023
View reviewed changes
src/config.ts Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

This pull request is deployed at test.editor.opencast.org/1100/2023-07-06_06-44-14/ .
It might take a few minutes for it to become available.

@github-actions github-actions bot added the status:conflicts Conflicts with another pull request or issue label Jul 12, 2023
@github-actions
Copy link

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions github-actions bot removed the status:conflicts Conflicts with another pull request or issue label Jul 17, 2023
@github-actions
Copy link

This pull request is deployed at test.editor.opencast.org/1100/2023-07-17_06-32-30/ .
It might take a few minutes for it to become available.

@github-actions
Copy link

This pull request is deployed at test.editor.opencast.org/1100/2023-07-17_06-34-45/ .
It might take a few minutes for it to become available.

@github-actions github-actions bot added the status:conflicts Conflicts with another pull request or issue label Sep 13, 2023
@github-actions
Copy link

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

Dennis Benz added 4 commits September 20, 2023 14:31
Add callback url for integration (opencast#1084)
9941a5d 
After finishing the editing, the user can now navigate back to the calling system using a button. For this, the integrating system can pass a `callbackUrl` url parameter to provide a return link. In the editor settings, the prefixes of the allowed callback urls must be provided to prevent malicious callback urls.
Fix inconsistent option of allowed callback prefixes
7e4a4d8
Fix icon and style of callback button
4c8ac97
Add setting option for callback system name
b88c774 
This allows to specify a system name to be displayed in the callback button instead of a generic name.
@github-actions github-actions bot removed the status:conflicts Conflicts with another pull request or issue label Sep 20, 2023
@github-actions
Copy link

This pull request is deployed at test.editor.opencast.org/1100/2023-09-20_14-09-31/ .
It might take a few minutes for it to become available.

@github-actions
Copy link

This pull request is deployed at test.editor.opencast.org/1100/2023-09-20_14-16-36/ .
It might take a few minutes for it to become available.

@dennis531
Copy link
Collaborator Author

dennis531 commented Sep 20, 2023 •
edited
Loading

Further changes:

  • Adds callbackSystem option to display the name of the callback system in the callback button.

@Arnei Arnei merged commit 54cb714 into opencast:main Sep 21, 2023
6 checks passed
@ziegenberg ziegenberg mentioned this pull request Sep 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkiesow lkiesow lkiesow left review comments

@Arnei Arnei Arnei approved these changes

Assignees
No one assigned
Labels
type:feature A new feature or feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dennis531 @lkiesow @Arnei