Remove all segments button

[dennis531]

Contains the following changes:

• Adds a button to delete all segments
• Adds a button for each segment to delete corresponding segment

Ref #1083

[github-actions]

This pull request is deployed at test.editor.opencast.org/1097/2023-07-04_07-56-11/ .
It might take a few minutes for it to become available.

[Arnei]

Short comment:

A "Delete All" Button seems completely superfluous to me. What's the use case?

Also don't like the buttons in the segments. Small, so hard to hit with a mouse. Overlap issues for a series of smaller cuts. Hardly read as buttons. I get that first clicking into a segment before you can click on the delete button is not the best UX, but that's exactly what the keyboard shortcuts are for.

[lkiesow]

I think you misunderstood #1083. I think what @kweingaertne wants is not to mark the content for removal, but to be able to quickly remove all segments itself. Right now, you would do that by starting somewhere and hitting the “Merge Left/Right” buttons over and over again.

Marking all segments for removal doesn't really make sense because you would end up with a 0 seconds long video file which should then fail to process as Opencast would tell you that this doesn't really make sense :D

[lkiesow]

I'm also not the biggest fan of the icon on the timeline. The old editor had several of them and I would like to not see them creep back one after another. Maybe instead as a “pro” feature to easily access the functionality implement #943 instead?

What do you think, @kweingaertne?

[lkiesow]

Finally (for the next time), having one feature/change pre pull request makes these changes easier to discuss, review and merge.

[github-actions]

This pull request is deployed at test.editor.opencast.org/1097/2023-09-04_10-46-22/ .
It might take a few minutes for it to become available.

[dennis531]

Now the button Merge All allows to merge all segments into a single segment.
Additionally, the delete button on each segment is removed.

[Arnei]

Looks good to me, code-wise and all. Just found one small behavioural change.

Usually when merging segments, the resulting segment inherits the "deleted state" of the previously selected segment. So if I select a "blue" segment and merge it with "red", the resulting segment is "blue". This is not true for the specific case in which I select a "red" segment" and merge it left with a "blue" segment. The resulting segment is "blue" instead of "red". Could you fix that?

[dennis531]

Usually when merging segments, the resulting segment inherits the "deleted state" of the previously selected segment. So if I select a "blue" segment and merge it with "red", the resulting segment is "blue". This is not true for the specific case in which I select a "red" segment" and merge it left with a "blue" segment. The resulting segment is "blue" instead of "red". Could you fix that?

Thanks for noticing. It should be fixed now.

[github-actions]

This pull request is deployed at test.editor.opencast.org/1097/2023-09-04_13-53-50/ .
It might take a few minutes for it to become available.

[github-actions]

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

[github-actions]

This pull request is deployed at test.editor.opencast.org/1097/2023-09-21_09-50-49/ .
It might take a few minutes for it to become available.

[dennis531]

Usually when merging segments, the resulting segment inherits the "deleted state" of the previously selected segment. So if I select a "blue" segment and merge it with "red", the resulting segment is "blue". This is not true for the specific case in which I select a "red" segment" and merge it left with a "blue" segment. The resulting segment is "blue" instead of "red". Could you fix that?

Thanks for noticing. It should be fixed now.

During solving the merge conflicts, I have noticed that this problem was still present. Hopefully, this is solved now.