Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "remove all segments" function #1083

Closed
kweingaertne opened this issue Jun 26, 2023 · 6 comments
Closed

Add "remove all segments" function #1083

kweingaertne opened this issue Jun 26, 2023 · 6 comments
Assignees

Comments

@kweingaertne
Copy link

In the old editor, there was a button to remove all the segments automatically made in a given recording. Having this back would be a great quality of life improvement. Also, it would be great to be able to restore or delete segments without moving the cursor into the segment first. In the old editor, there was a little icon on the top right corner of every segment, letting you delete/ restore them without interrupting playback.

@dennis531 dennis531 self-assigned this Jul 3, 2023
dennis531 pushed a commit to dennis531/opencast-editor that referenced this issue Jul 4, 2023
dennis531 pushed a commit to dennis531/opencast-editor that referenced this issue Jul 4, 2023
@dagraf
Copy link

dagraf commented Aug 17, 2023

I'm in favour of having the "Remove all segments" functions back. Imagine having automatic silence detections activated on your Opencast installation and a lecturer who does not want his/her pauses deleted. That would need quite a lot of clicks.

@Arnei
Copy link
Member

Arnei commented Sep 8, 2023

Regarding the second part of this issue: I personally dislike the icons in the top right segment corner. They're small and thus hard to hit, they disappear if segments are too small, and are often just as far away from the cursor as the general delete button. I think keyboard shortcuts are a better solution.

But you mentioned that would like to be able to delete/restore segments without interrupting playback. I had not considered this previously, could you describe your use case in greater detail? I'd be interested in hearing if others have the same use case.

@dagraf
Copy link

dagraf commented Sep 11, 2023

I agree here with @Arnei: I like that we do not have the icons in the top right segment corner anymore. Deleting/restoring segments without interrupting playback is still possible if the option "Preview mode" is DEactivated.

@ziegenberg
Copy link
Member

If you click "Merge All" Segments, this removes all segments. Which is basically the description of this issue. I would consider this as "solved".

@dagraf
Copy link

dagraf commented Sep 21, 2023

@ziegenberg: I guess your referring tho #1097? If so, I would consider it as solved, too.

@Arnei
Copy link
Member

Arnei commented Sep 21, 2023

Cool, closing this then. If people want to further discuss the second part of this issue, they may open another issue for that.

@Arnei Arnei closed this as completed Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

5 participants