Merge pull request #1267 from Arnei/fix-subtitles-not-getting-saved-t…

…o-opencast-for-new-subtitles Fix subtiles not saved for new subtitles
opencast · Feb 29, 2024 · 6581d0f · 6581d0f
2 parents 1b5028b + 1681ee8
commit 6581d0f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/main/WorkflowConfiguration.tsx b/src/main/WorkflowConfiguration.tsx
@@ -30,7 +30,10 @@ import {
   selectPostStatus,
   setHasChanges as metadataSetHasChanges,
 } from "../redux/metadataSlice";
-import { selectSubtitles } from "../redux/subtitleSlice";
+import {
+  selectSubtitles,
+  setHasChanges as subtitleSetHasChanges,
+} from "../redux/subtitleSlice";
 import { serializeSubtitle } from "../util/utilityFunctions";
 import { useTheme } from "../themes";
 
@@ -105,6 +108,7 @@ export const SaveAndProcessButton: React.FC<{ text: string; }> = ({ text }) => {
       dispatch(setEnd({ hasEnded: true, value: "success" }));
       dispatch(videoSetHasChanges(false));
       dispatch(metadataSetHasChanges(false));
+      dispatch(subtitleSetHasChanges(false));
     }
   }, [dispatch, metadataStatus, workflowStatus]);
 

diff --git a/src/redux/subtitleSlice.ts b/src/redux/subtitleSlice.ts
@@ -81,7 +81,7 @@ export const subtitleSlice = createSlice({
     setCueAtIndex: (state, action: PayloadAction<{ identifier: string, cueIndex: number, newCue: SubtitleCue; }>) => {
       if (action.payload.cueIndex < 0 ||
         action.payload.cueIndex >= state.subtitles[action.payload.identifier].cues.length) {
-        console.log("WARNING: Tried to set segment for subtitle " + action.payload.identifier +
+        console.warn("Tried to set segment for subtitle " + action.payload.identifier +
           " but was out of range");
         return;
       }
@@ -93,6 +93,9 @@ export const subtitleSlice = createSlice({
       cue.startTime = Math.round(action.payload.newCue.startTime);
       cue.endTime = Math.round(action.payload.newCue.endTime);
 
+      if (cue.tree.children.length <= 0) {
+        cue.tree.children[0] = { type: "text", value: action.payload.newCue.text };
+      }
       cue.tree.children[0].value = action.payload.newCue.text;
 
       state.subtitles[action.payload.identifier].cues[action.payload.cueIndex] = cue;