Fix translation for table name in EditTableModal #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the edit table modal, the names for the tables were only properly translated for the event and series tables. Should now be properly translated everywhere. Arguably the approach to solving this problem chosen here is suboptimal at best. Another approach would be to add new translation strings under PREFERENCES.TABLE.CAPTION.*. Let me know which you think is better.
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
|
This pull request is deployed at test.admin-interface.opencast.org/910/2024-09-11_12-22-25/ . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #414.
In the edit table modal, the names for the tables were only properly translated for the event and series tables. Should now be properly translated everywhere.
Arguably the approach to solving this problem chosen here is suboptimal at best. Another approach would be to add new translation strings under PREFERENCES.TABLE.CAPTION.*. Let me know which you think is better.