Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional features for Tobira integration #878

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Commits on Sep 18, 2024

  1. Add Tobira tab to event details modal

    This adapts the Tobira details component from series details
    to be usable in both series and event context.
    
    Note that an Opencast patch (todo: link that patch)
    is necessary for this to work.
    owi92 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    60ee697 View commit details
    Browse the repository at this point in the history
  2. Add checkboxes to (de)select Tobira series path

    This was requested by Bern. It is still possible to select
    and deselect the path by clicking it's name, but next to that
    a checkbox was added for visual clarity.
    
    The checkbox is only shown when the path can be selected
    (the page needs to be empty).
    owi92 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    399ca8d View commit details
    Browse the repository at this point in the history
  3. Reformat/-factor some Tobira related files

    This factors out some code and applies some (yet non-inforced)
    linting rules, ES6 syntax and formatting to limit some indentation
    levels and improve readability.
    owi92 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    5cf8bd3 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Make tobira series path editable

    Another feature requested by Bern, this adds the necessary
    API and UI functions/components to edit existing series paths.
    
    Editing is only allowed if the page with that path has no
    other blocks than that of the series.
    owi92 committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    d9ffc9d View commit details
    Browse the repository at this point in the history
  2. Factor out some "save edit" footer code

    This pulls the code into a component to limit duplication.
    The component can be used when "cancel" and "save" buttons
    are needed in modal tabs that allow editing things like
    access policies.
    
    This makes it easier to reuse and limits duplicated code.
    owi92 committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    8ba6b76 View commit details
    Browse the repository at this point in the history
  3. Adjust some typings

    Most notably the series title (in Tobira context)
    was made optional, so we don't have to pass an empty
    string to Tobira when it's not specified.
    owi92 committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    068c8bf View commit details
    Browse the repository at this point in the history
  4. Adjust markup to be less matryoschka-like

    This came up and was suggested in the technical meeting.
    It does however mean that the Tobira tab will not really
    follow the examplary design-"principles" of the other tabs.
    owi92 committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    0bcbae7 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b7237ca View commit details
    Browse the repository at this point in the history
  6. Always show checkboxes

    Previously I had them hidden if they couldn't be checked.
    After some feedback from Bern we decided to show them anyway, but
    add a tooltip to explain why they can't be checked. The disabled
    style isn't really that striking or self explanatory.
    I hope this will prevent at least some confusion.
    owi92 committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    9cba7a6 View commit details
    Browse the repository at this point in the history
  7. Adjust http error handling and notifications

    503 errors mean that Tobira either isn't configured, or not
    configured correcty in Opencast. Unfortunately, it doesn't
    distinguish between the two.
    Since it might very well be the former, I think we shouldn't
    show the error as a notification in the UI.
    Instead there will be an info in console saying "Tobira isn't
    configured (correctly)" and the Tobira tab will be hidden.
    This solution isn't optimal but I think it's the best we
    can do for now.
    
    The other errors (404, 500) will trigger notifications that
    are shown in the respective Tobira tab.
    owi92 committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    3ca089a View commit details
    Browse the repository at this point in the history