-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional features for Tobira integration #878
base: main
Are you sure you want to change the base?
Commits on Sep 18, 2024
-
Add Tobira tab to event details modal
This adapts the Tobira details component from series details to be usable in both series and event context. Note that an Opencast patch (todo: link that patch) is necessary for this to work.
Configuration menu - View commit details
-
Copy full SHA for 60ee697 - Browse repository at this point
Copy the full SHA 60ee697View commit details -
Add checkboxes to (de)select Tobira series path
This was requested by Bern. It is still possible to select and deselect the path by clicking it's name, but next to that a checkbox was added for visual clarity. The checkbox is only shown when the path can be selected (the page needs to be empty).
Configuration menu - View commit details
-
Copy full SHA for 399ca8d - Browse repository at this point
Copy the full SHA 399ca8dView commit details -
Reformat/-factor some Tobira related files
This factors out some code and applies some (yet non-inforced) linting rules, ES6 syntax and formatting to limit some indentation levels and improve readability.
Configuration menu - View commit details
-
Copy full SHA for 5cf8bd3 - Browse repository at this point
Copy the full SHA 5cf8bd3View commit details
Commits on Sep 30, 2024
-
Make tobira series path editable
Another feature requested by Bern, this adds the necessary API and UI functions/components to edit existing series paths. Editing is only allowed if the page with that path has no other blocks than that of the series.
Configuration menu - View commit details
-
Copy full SHA for d9ffc9d - Browse repository at this point
Copy the full SHA d9ffc9dView commit details -
Factor out some "save edit" footer code
This pulls the code into a component to limit duplication. The component can be used when "cancel" and "save" buttons are needed in modal tabs that allow editing things like access policies. This makes it easier to reuse and limits duplicated code.
Configuration menu - View commit details
-
Copy full SHA for 8ba6b76 - Browse repository at this point
Copy the full SHA 8ba6b76View commit details -
Most notably the series title (in Tobira context) was made optional, so we don't have to pass an empty string to Tobira when it's not specified.
Configuration menu - View commit details
-
Copy full SHA for 068c8bf - Browse repository at this point
Copy the full SHA 068c8bfView commit details -
Adjust markup to be less matryoschka-like
This came up and was suggested in the technical meeting. It does however mean that the Tobira tab will not really follow the examplary design-"principles" of the other tabs.
Configuration menu - View commit details
-
Copy full SHA for 0bcbae7 - Browse repository at this point
Copy the full SHA 0bcbae7View commit details -
Configuration menu - View commit details
-
Copy full SHA for b7237ca - Browse repository at this point
Copy the full SHA b7237caView commit details -
Previously I had them hidden if they couldn't be checked. After some feedback from Bern we decided to show them anyway, but add a tooltip to explain why they can't be checked. The disabled style isn't really that striking or self explanatory. I hope this will prevent at least some confusion.
Configuration menu - View commit details
-
Copy full SHA for 9cba7a6 - Browse repository at this point
Copy the full SHA 9cba7a6View commit details -
Adjust http error handling and notifications
503 errors mean that Tobira either isn't configured, or not configured correcty in Opencast. Unfortunately, it doesn't distinguish between the two. Since it might very well be the former, I think we shouldn't show the error as a notification in the UI. Instead there will be an info in console saying "Tobira isn't configured (correctly)" and the Tobira tab will be hidden. This solution isn't optimal but I think it's the best we can do for now. The other errors (404, 500) will trigger notifications that are shown in the respective Tobira tab.
Configuration menu - View commit details
-
Copy full SHA for 3ca089a - Browse repository at this point
Copy the full SHA 3ca089aView commit details