Port Tobira integration #313
Conversation
The old admin ui had an integration for tobira in the series details and new series modal. This starts porting the integration by laying out some basic DOM structure and adding CSS and translations. I.e. it should already look similar to the old admin ui, but there is no actual functionality yet.
Ports basic page functionality. This still does not do anything useful, since I currently cannot test with real data to fully understand how this is supposed to work. But most of the code from the old admin ui is now here.
|
This pull request has conflicts ☹ |
Can now actually be used to link new series to exisiting or new tobira pages, or view linked pages in the series details.
When creating a new series, notifications for the tobira tab would not show at all. This fixes that.
While the user was warned about malformed input, they were not actually prevented from submitting it. This hacks our custom validation into WizardNavigationButtons.tsx to achieve validation.
|
Ready for review! (...as soon as I fix the merge conficts I guess) |
|
This pull request has conflicts ☹ |
Arnei
force-pushed
the
tobira-series-integration
branch
from
d0a08a6
to
a09b946
Compare
|
Without configuring a Tobira for my Opencast installation I get
Otherwise I still gotta figure out how to easily test this locally. |
|
This pull request has conflicts ☹ |
There was a problem hiding this comment.
Conflicts fixed, see: https://github.com/KatrinIhler/opencast-admin-interface/tree/pr313-conflicts-fixed
The error for a non-working Tobira connection should appear in the Tobira tab, not the access tab, like in the old UI (see also comment above).
Minor differences in style between the two UIs (new one on the left), note the missing space between the table and the text above.
Obscure bug: The path is always one letter behind the one entered in the text field. (see text below and summary).
Apart from the fact that I can't figure out how to select existing pages (in the old and the new UI, but maybe it's because they aren't empty?) and the issues mentioned above, it looks fine.
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
Arnei
force-pushed
the
tobira-series-integration
branch
from
66d4cf7
to
bf2ec50
Compare
|
This pull request has conflicts ☹ |
There was a problem hiding this comment.
This is working and a clear improvement, and not breaking anything as far as I can tell.
There are some additional features that were requested in #311 after this was already finished and that I will be working on, but their omission shouldn't block merging what's already here.
|
This pull request has conflicts ☹ |
|
Thanks for the review @owi92. There were some merge conflicts since your review, would you mind quickly checking again if this still works to your satisfaction? |
|
Yes, still appears to be working 👌
If you want you can still fix those, but I don't see them as blockers and I can also do that in my upcoming pull request. |
Seen that elsewhere, like not a cause of this PR.
Would be great if you could fix that. |
|
This pull request has conflicts ☹ |
|
This pull request has conflicts ☹ |
|
This pull request has conflicts ☹ |
|
Merging this even though there is still a requested change, as following reviews have approved this PR and it is already being used in #878. |
Resolves #311
The old admin ui had an integration for tobira in the series details and new series modal. This ports the integration to our new ui. The user experience could arguably be improved upon, but this should work and be familiar to users who already used the integration in the old admin ui.