Adjust some typings

Most notably the series title (in Tobira context) was made optional, so we don't have to pass an empty string to Tobira when it's not specified.
opencast · Aug 13, 2024 · ccdd703 · ccdd703
1 parent 62994d0
commit ccdd703
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 7 deletions.
diff --git a/src/components/events/partials/ModalTabsAndPages/NewTobiraPage.tsx b/src/components/events/partials/ModalTabsAndPages/NewTobiraPage.tsx
@@ -109,7 +109,7 @@ const NewTobiraPage = <T extends RequiredTobiraFormProps>({
 		goto(formik.values.breadcrumbs.splice(index)[0]);
 	};
 
-	const select = (page: TobiraPage | undefined) => {
+	const select = (page?: TobiraPage) => {
 		if (!page || !page.new) {
 			stopEditing();
 		}
@@ -161,7 +161,6 @@ const NewTobiraPage = <T extends RequiredTobiraFormProps>({
 			new: true,
 			children: [],
 			ancestors: [],
-			title: "",
 			path: "",
 			subpages: "",
 			blocks: [],

diff --git a/src/components/events/partials/wizards/NewSeriesSummary.tsx b/src/components/events/partials/wizards/NewSeriesSummary.tsx
@@ -20,7 +20,7 @@ import { TobiraPage } from "../../../../slices/seriesSlice";
 interface RequiredFormProps {
 	theme: string,
 	acls: TransformedAcl[],
-	selectedPage: TobiraPage | undefined,
+	selectedPage?: TobiraPage,
 }
 
 const NewSeriesSummary = <T extends RequiredFormProps>({

diff --git a/src/components/events/partials/wizards/NewSeriesWizard.tsx b/src/components/events/partials/wizards/NewSeriesWizard.tsx
@@ -88,7 +88,7 @@ const NewSeriesWizard: React.FC<{
 			acls: TransformedAcl[];
 			theme: string;
 			breadcrumbs: TobiraPage[];
-			selectedPage: TobiraPage | undefined;
+			selectedPage?: TobiraPage;
 		}
 	) => {
 		setSnapshot(values);
@@ -110,7 +110,7 @@ const NewSeriesWizard: React.FC<{
 			acls: TransformedAcl[];
 			theme: string;
 			breadcrumbs: TobiraPage[];
-			selectedPage: TobiraPage | undefined;
+			selectedPage?: TobiraPage;
 		},
 		twoPagesBack?: boolean
 	) => {

diff --git a/src/configs/modalConfig.ts b/src/configs/modalConfig.ts
@@ -95,7 +95,7 @@ export const initialFormValuesNewSeries: {
 	theme: string,
 
 	breadcrumbs: TobiraPage[],
-	selectedPage: TobiraPage | undefined,
+	selectedPage?: TobiraPage,
 	[key: string]: any,  // Metadata fields that are getting added later
 } = {
 	acls: [

diff --git a/src/slices/seriesSlice.ts b/src/slices/seriesSlice.ts
@@ -42,7 +42,7 @@ type Theme = {
 }
 
 export interface TobiraPage {
-	title: string | undefined,
+	title?: string,
 	path: string,
 	segment: string,
 	children: TobiraPage[],