honor retry-after-ms for azure clients #1046
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Amazing, thank you Krista! I actually think we should just bake this in and always handle that header if it's available. I've gone ahead and incorporated the change on an internal PR; I don't have tests yet and may copy yours. Thanks for the great work here! |
|
Thanks Alex, really appreciate it! |
|
(update, we are still putting some finishing touches on this but hope to roll it out in the coming days, so will go ahead and close this PR – thanks again Krista!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes being requested
Related feature request: #957
@rattrayalex Coming back from the holidays and I see we're getting requests to support retry-after-ms on the Azure side. If it's easier / less work for you, I added the retry-after-ms logic to the Azure clients only in this PR. This assumes that it is okay to override the the internal calculate retry timeout method, but let me know if you have a different recommendation. Thanks so much!
Additional context & links