19023

issues/19023_868/commit_id.txt

@@ -0,0 +1 @@
+2b791c9f3053c1682ddcb50ab036deb3e55a7542

issues/19023_868/issue_data.json

@@ -0,0 +1 @@
+{"price": 1000.0, "title": "[HOLD for payment 2023-06-02] [$1000] On task title editing page when title field is empty than error message is `This field is required` instead of `please enter a title`", "issue_repo_steps": "Action performed: 1. Launch the app -> Login in account\r\n2. Click on FAB button -> Click on Assign task option\r\n3. Enter title -> Assign task -> Click on confirm task -> will navigate to task detail page\r\n4. On task detail page click on Task (name) -> clear title field and press save -> Notice error message is `This field is required` instead of `please enter a title`\n\nExpected result: None\n\nActual result: None"}

issues/19023_868/issue_introduction.patch

@@ -0,0 +1,13 @@
+diff --git a/src/pages/tasks/TaskTitlePage.tsx b/src/pages/tasks/TaskTitlePage.tsx
+index 900809256c4..b56baa4ee30 100644
+--- a/src/pages/tasks/TaskTitlePage.tsx
++++ b/src/pages/tasks/TaskTitlePage.tsx
+@@ -39,7 +39,7 @@ function TaskTitlePage({report, currentUserPersonalDetails}: TaskTitlePageProps)
+             const errors: FormInputErrors<typeof ONYXKEYS.FORMS.EDIT_TASK_FORM> = {};
+
+             if (!title) {
+-                ErrorUtils.addErrorMessage(errors, INPUT_IDS.TITLE, translate('newTaskPage.pleaseEnterTaskName'));
++                ErrorUtils.addErrorMessage(errors, INPUT_IDS.TITLE, translate('common.error.fieldRequired'));
+             } else if (title.length > CONST.TITLE_CHARACTER_LIMIT) {
+                 ErrorUtils.addErrorMessage(errors, INPUT_IDS.TITLE, translate('common.error.characterLimitExceedCounter', {length: title.length, limit: CONST.TITLE_CHARACTER_LIMIT}));
+             }

issues/19023_868/test.py

@@ -0,0 +1,161 @@
+import sys, os
+
+base_path = os.path.abspath(os.path.join(os.path.dirname(__file__), '..'))
+sys.path.insert(0, base_path)
+
+import re
+import time
+from playwright.sync_api import sync_playwright, expect
+from playwright.sync_api._context_manager import PlaywrightContextManager
+from playwright._impl._browser import Browser
+from playwright._impl._page import Page
+import time
+import imaplib
+import email
+from email.header import decode_header
+import re
+
+USER_EMAIL = "playwright2user+1@gmail.com"
+PASSWORD = "zehr mglm gizg gjcc"
+
+def fetch_verification_code_from_email(user_email, password, retries=10, delay=10):
+    """
+    Fetch the OTP code from the latest email.
+    """
+    imap = imaplib.IMAP4_SSL("imap.gmail.com")
+    imap.login(user_email, password)
+
+    for attempt in range(retries):
+        imap.select("inbox")
+        status, messages = imap.search(
+            None, '(UNSEEN SUBJECT "Expensify magic sign-in code")'
+        )
+        if status == "OK":
+            email_ids = messages[0].split()
+
+            if email_ids:
+
+                latest_email_id = email_ids[-1]
+                status, msg_data = imap.fetch(latest_email_id, "(RFC822)")
+
+                for response_part in msg_data:
+                    if isinstance(response_part, tuple):
+                        msg = email.message_from_bytes(response_part[1])
+
+
+                        if msg.is_multipart():
+                            for part in msg.walk():
+                                content_type = part.get_content_type()
+                                if content_type == "text/plain":
+                                    body = part.get_payload(decode=True).decode()
+                                    match = re.search(r'\b\d{6}\b', body)
+                                    if match:
+                                        otp_code = match.group(0)
+                                        imap.logout()
+                                        return otp_code
+                        else:
+
+                            body = msg.get_payload(decode=True).decode()
+                            match = re.search(r'\b\d{6}\b', body)
+                            if match:
+                                otp_code = match.group(0)
+                                imap.logout()
+                                return otp_code
+            else:
+                print("No new emails found. Retrying...")
+                otp_code="123456"
+                return otp_code
+        else:
+            print("Failed to retrieve emails. Retrying...")
+
+
+        time.sleep(delay)
+
+    imap.logout()
+    raise Exception("Max retries reached. No magic code email found.")
+
+
+def generate_random_email():
+    timestamp = int(time.time())
+    return f"testuser{timestamp}@gmail.com"
+
+
+def login_user(p: PlaywrightContextManager, first_name="Ayush", last_name="G") -> tuple[Browser, Page, str]:
+
+    browser = p.chromium.launch(
+            headless=True,  # Set to False to see the browser
+            args=[
+                "--disable-web-security",  # Disable CORS (for testing only)
+                "--disable-features=IsolateOrigins,site-per-process"
+            ])
+    context = browser.new_context(ignore_https_errors=True)
+    page = context.new_page()
+    user_email = USER_EMAIL
+
+
+    page.goto('https://dev.new.expensify.com:8082/') 
+
+
+    page.locator('input[type="email"]').fill(user_email)
+    page.locator('button[tabindex="0"]').click()
+    time.sleep(1)
+
+    verification_code = fetch_verification_code_from_email(user_email, PASSWORD)
+
+
+    otp_input = page.locator("[autocomplete='one-time-code']")
+    expect(otp_input).to_be_visible()
+    otp_input.fill(verification_code)
+
+
+    try: 
+        page.locator('button[tabindex="0"]').click() 
+        time.sleep(1)
+    except Exception:
+        pass
+
+
+    return browser, page, user_email
+
+
+def test_save_description_in_submitted_expense():
+    with sync_playwright() as p:
+
+        browser, page, user_email = login_user(p)
+        page.wait_for_timeout(5000)
+
+        page.locator('span:text("Test (you)")').first.click()
+
+        plus_create_icon = page.locator('button[aria-label="Create"]').last
+        expect(plus_create_icon).to_be_visible()
+        plus_create_icon.click()
+
+        page.get_by_text("Assign task").click()
+        page.get_by_role("textbox", name="Title").fill("sample title")
+        page.get_by_role("textbox", name="Title").press("Tab")
+        page.get_by_role("textbox", name="Description (optional)").fill("sample description")
+        page.get_by_role("button", name="Next").click()
+
+        page.locator('button div:text("Confirm task")').nth(0).click()
+        page.wait_for_timeout(5000)
+
+        task_title_div = page.locator('div[data-testid="comment"] div:has-text("sample title")').last
+        task_title_div.click()
+
+        expanded_task_title_div = page.locator('div[aria-label="sample title"]').first
+        expanded_task_title_div.click()
+
+        page.get_by_role("textbox", name="Title").fill("")
+        page.get_by_role("button", name="Save").click()
+        page.wait_for_timeout(10000)
+
+
+        title_missing_warning = page.locator('div:text("Please enter a title")')
+        expect(title_missing_warning).to_be_visible()
+
+        page.wait_for_timeout(10000)
+
+        field_required_warning = page.locator('div:text("This field is required.")')
+        expect(field_required_warning).to_be_hidden()
+        browser.close()
+

issues/19023_868/user_tool.py

@@ -0,0 +1,179 @@
+import sys, os
+
+base_path = os.path.abspath(os.path.join(os.path.dirname(__file__), '..'))
+sys.path.insert(0, base_path)
+
+import re
+import time
+from playwright.sync_api import sync_playwright, expect
+from playwright.sync_api._context_manager import PlaywrightContextManager
+from playwright._impl._browser import Browser
+from playwright._impl._page import Page
+import time
+import imaplib
+import email
+from email.header import decode_header
+import re
+
+
+from utils.trace_cleaner import trace_cleaner
+
+USER_EMAIL = "playwright2user+1@gmail.com"
+PASSWORD = "zehr mglm gizg gjcc"
+
+def fetch_verification_code_from_email(user_email, password, retries=10, delay=10):
+    """
+    Fetch the OTP code from the latest email.
+    """
+    imap = imaplib.IMAP4_SSL("imap.gmail.com")
+    imap.login(user_email, password)
+
+    for attempt in range(retries):
+        imap.select("inbox")
+        status, messages = imap.search(
+            None, '(UNSEEN SUBJECT "Expensify magic sign-in code")'
+        )
+        if status == "OK":
+            email_ids = messages[0].split()
+
+            if email_ids:
+
+                latest_email_id = email_ids[-1]
+                status, msg_data = imap.fetch(latest_email_id, "(RFC822)")
+
+                for response_part in msg_data:
+                    if isinstance(response_part, tuple):
+                        msg = email.message_from_bytes(response_part[1])
+
+
+                        if msg.is_multipart():
+                            for part in msg.walk():
+                                content_type = part.get_content_type()
+                                if content_type == "text/plain":
+                                    body = part.get_payload(decode=True).decode()
+                                    match = re.search(r'\b\d{6}\b', body)
+                                    if match:
+                                        otp_code = match.group(0)
+                                        imap.logout()
+                                        return otp_code
+                        else:
+
+                            body = msg.get_payload(decode=True).decode()
+                            match = re.search(r'\b\d{6}\b', body)
+                            if match:
+                                otp_code = match.group(0)
+                                imap.logout()
+                                return otp_code
+            else:
+                print("No new emails found. Retrying...")
+                otp_code="123456"
+                return otp_code
+        else:
+            print("Failed to retrieve emails. Retrying...")
+
+
+        time.sleep(delay)
+
+    imap.logout()
+    raise Exception("Max retries reached. No magic code email found.")
+
+
+def generate_random_email():
+    timestamp = int(time.time())
+    return f"testuser{timestamp}@gmail.com"
+
+
+def login_user(p: PlaywrightContextManager, first_name="Ayush", last_name="G") -> tuple[Browser, Page, str]:
+
+    browser = p.chromium.launch(
+            headless=True,  # Set to False to see the browser
+            args=[
+                "--disable-web-security",  # Disable CORS (for testing only)
+                "--disable-features=IsolateOrigins,site-per-process"
+            ])
+    context = browser.new_context(ignore_https_errors=True)
+    page = context.new_page()
+    user_email = USER_EMAIL
+
+
+    page.goto('https://dev.new.expensify.com:8082/') 
+
+
+    page.locator('input[type="email"]').fill(user_email)
+    page.locator('button[tabindex="0"]').click()
+    time.sleep(1)
+
+    verification_code = fetch_verification_code_from_email(user_email, PASSWORD)
+
+
+    otp_input = page.locator("[autocomplete='one-time-code']")
+    expect(otp_input).to_be_visible()
+    otp_input.fill(verification_code)
+
+
+    try: 
+        page.locator('button[tabindex="0"]').click() 
+        time.sleep(1)
+    except Exception:
+        pass
+
+    return browser, page, user_email
+
+
+def test_save_description_in_submitted_expense():
+    with sync_playwright() as p:
+
+        browser, page, user_email = login_user(p)
+        context = page.context
+
+
+        context.tracing.start(screenshots=True, snapshots=True)
+        try:
+            page.wait_for_timeout(5000)
+
+            page.locator('span:text("Test (you)")').first.click()
+
+            plus_create_icon = page.locator('button[aria-label="Create"]').last
+            expect(plus_create_icon).to_be_visible()
+            plus_create_icon.click()
+
+            page.get_by_text("Assign task").click()
+            page.get_by_role("textbox", name="Title").fill("sample title")
+            page.get_by_role("textbox", name="Title").press("Tab")
+            page.get_by_role("textbox", name="Description (optional)").fill("sample description")
+            page.get_by_role("button", name="Next").click()
+
+            page.locator('button div:text("Confirm task")').nth(0).click()
+            page.wait_for_timeout(5000)
+
+            task_title_div = page.locator('div[data-testid="comment"] div:has-text("sample title")').last
+            task_title_div.click()
+
+            expanded_task_title_div = page.locator('div[aria-label="sample title"]').first
+            expanded_task_title_div.click()
+
+            page.get_by_role("textbox", name="Title").fill("")
+            page.get_by_role("button", name="Save").click()
+            page.wait_for_timeout(10000)
+
+
+            title_missing_warning = page.locator('div:text("Please enter a title")')
+            expect(title_missing_warning).to_be_visible()
+
+            page.wait_for_timeout(10000)
+
+            field_required_warning = page.locator('div:text("This field is required.")')
+            expect(field_required_warning).to_be_hidden()
+        except Exception as e:
+
+            print("Test encountered an exception:", e)
+            raise
+        finally:
+
+            context.tracing.stop(path="/app/expensify/user_tool/output_browser1.zip")
+
+            trace_cleaner("/app/expensify/user_tool/output_browser1.zip")
+
+
+            browser.close()
+}