Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cffi: we should probably not include capi stuff in the standard crate #53

Closed
cyphar opened this issue Aug 13, 2024 · 0 comments · Fixed by #59
Closed

cffi: we should probably not include capi stuff in the standard crate #53

cyphar opened this issue Aug 13, 2024 · 0 comments · Fixed by #59
Labels
api/cffi Related to the C-FFI API. api/rust Related to the Rust API.

Comments

@cyphar
Copy link
Member

cyphar commented Aug 13, 2024

We set panic = "abort" unconditionally for our builds, which is not good for a general-purpose crate. And the capi code should probably not be included at all for Rust users (unless we decide to have libpathrs-sys for license reasons -- see #50 -- but you still wouldn't want to use it for standard uses).

cargo-c is meant to make this easier, so we can probably use that.

@cyphar cyphar added api/cffi Related to the C-FFI API. api/rust Related to the Rust API. labels Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api/cffi Related to the C-FFI API. api/rust Related to the Rust API.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant