Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update retention policy use error shard duration #183

Merged
merged 1 commit into from
Oct 12, 2024
Merged

fix: update retention policy use error shard duration #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions opengemini/retention_policy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,8 +165,8 @@ func (c *client) UpdateRetentionPolicy(database string, rpConfig RpConfig, isDef
if len(rpConfig.IndexDuration) > 0 {
buf.WriteString(fmt.Sprintf(" INDEX DURATION %s", rpConfig.IndexDuration))
}
if len(rpConfig.IndexDuration) > 0 {
buf.WriteString(fmt.Sprintf(" INDEX DURATION %s", rpConfig.IndexDuration))
if len(rpConfig.ShardGroupDuration) > 0 {
buf.WriteString(fmt.Sprintf(" SHARD DURATION %s", rpConfig.ShardGroupDuration))
}
if isDefault {
buf.WriteString(" DEFAULT")
Expand Down
15 changes: 14 additions & 1 deletion opengemini/retention_policy_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,9 @@
package opengemini

import (
"github.com/stretchr/testify/require"
"testing"

"github.com/stretchr/testify/require"
)

func TestClientCreateRetentionPolicy(t *testing.T) {
Expand Down Expand Up @@ -94,13 +95,25 @@ func TestClientUpdateRetentionPolicy(t *testing.T) {
databaseName := randomDatabaseName()
err := c.CreateDatabase(databaseName)
require.Nil(t, err)

err = c.UpdateRetentionPolicy(databaseName, RpConfig{Name: "autogen", Duration: "300d"}, true)
require.Nil(t, err)
rpResult, err := c.ShowRetentionPolicies(databaseName)
require.Nil(t, err)
require.Equal(t, len(rpResult), 1)
require.Equal(t, rpResult[0].Name, "autogen")
require.Equal(t, rpResult[0].Duration, "7200h0m0s")

err = c.UpdateRetentionPolicy(databaseName, RpConfig{Name: "autogen", Duration: "300d", ShardGroupDuration: "2h", IndexDuration: "4h"}, true)
require.Nil(t, err)
rpResult, err = c.ShowRetentionPolicies(databaseName)
require.Nil(t, err)
require.Equal(t, len(rpResult), 1)
require.Equal(t, rpResult[0].Name, "autogen")
require.Equal(t, rpResult[0].Duration, "7200h0m0s")
require.Equal(t, rpResult[0].IndexDuration, "4h0m0s")
require.Equal(t, rpResult[0].ShardGroupDuration, "2h0m0s")

err = c.DropDatabase(databaseName)
require.Nil(t, err)
}
Loading