Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Make version-if-file.sh more robust #6272

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Feb 10, 2025

  • Fixes Auto-update versions script failing #6271
  • Makes scripts/auto-update/version-in-file.sh a little more resilient when it comes to processing the latest version ID. It now ignores any prefix, extracting the semver from the end of the ID.
  • Looks for existing PRs by matching on branch names, this avoids semantic-conventions potentially being skipped because there was a PR over semantic-conventions-java
  • Tested locally. Let's see if it works in GH.

/cc @jack-berg @TylerHelmuth

@chalin chalin added the CI/infra CI & infrastructure label Feb 10, 2025
@chalin chalin requested a review from a team as a code owner February 10, 2025 18:11
Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM.

@chalin chalin force-pushed the chalin-im-auto-vers-update-2025-02-10 branch from 48ddb60 to f24b2f3 Compare February 10, 2025 18:20
@chalin chalin merged commit 3f8c981 into open-telemetry:main Feb 10, 2025
18 checks passed
@chalin chalin deleted the chalin-im-auto-vers-update-2025-02-10 branch February 10, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-update versions script failing
2 participants