Fix invalid links to Prometheus, API pages, and more #6235
Conversation
chalin
commented
Feb 6, 2025
chalin
commented
- Contributes to [chore] Ensure that external link fragments are valid #6196
opentelemetrybot
requested review from
a team and
djaglowski
and removed request for
a team
| [Prometheus]: | ||
| https://prometheus.io/docs/prometheus/latest/feature_flags/#otlp-receiver | ||
| https://prometheus.io/docs/prometheus/2.55/feature_flags/#otlp-receiver |
There was a problem hiding this comment.
This fixes the link, but the fact that an OTLP-receiver entry no longer exists in the latest version of the docs is probably an indication that this prose needs to be updated (and/or the link to point to something else in the latest docs)?
There was a problem hiding this comment.
@open-telemetry/collector-approvers ☝️
| [enable Prometheus' OTLP Receiver](https://prometheus.io/docs/prometheus/latest/feature_flags/#otlp-receiver) | ||
| [enable Prometheus' OTLP Receiver](https://prometheus.io/docs/prometheus/2.55/feature_flags/#otlp-receiver) |
There was a problem hiding this comment.
There was a problem hiding this comment.
@open-telemetry/collector-approvers ☝️
chalin
force-pushed
the
chalin-im-fix-links-2025-02-06
branch
from
3942587 to
f966a51
Compare
chalin
changed the title
chalin
force-pushed
the
chalin-im-fix-links-2025-02-06
branch
from
7ce1cec to
619c6dc
Compare
chalin
force-pushed
the
chalin-im-fix-links-2025-02-06
branch
from
842b344 to
7bccc70
Compare
| - [go.opentelemetry.io/collector/config/configauth/GRPCClientAuthenticator](https://pkg.go.dev/go.opentelemetry.io/collector/config/configauth#GRPCClientAuthenticator) | ||
| - [go.opentelemetry.io/collector/config/configauth/HTTPClientAuthenticator](https://pkg.go.dev/go.opentelemetry.io/collector/config/configauth#HTTPClientAuthenticator) |
There was a problem hiding this comment.
These link targets no longer exists (the fragments are invalid), so I've reworked the prose and instead linked to the section headings introduced by https://github.com/open-telemetry/opentelemetry-collector/pull/12309/files (which hasn't been published yet, but the links are still valid -- the link fragments will be validated once 12309 is published.
| - [Ecosystem](https://github.com/open-telemetry/opentelemetry-rust#ecosystem) | ||
| - [Overview of crates](https://github.com/open-telemetry/opentelemetry-rust#overview-of-crates) |
There was a problem hiding this comment.
This change was made via:
chalin
force-pushed
the
chalin-im-fix-links-2025-02-06
branch
from
b46f635 to
5aa6e4e
Compare
chalin
changed the title
chalin
force-pushed
the
chalin-im-fix-links-2025-02-06
branch
from
5aa6e4e to
870d252
Compare
chalin
force-pushed
the
chalin-im-fix-links-2025-02-06
branch
from
870d252 to
7405889
Compare
Context of change: - open-telemetry/opentelemetry-rust#1581
chalin
force-pushed
the
chalin-im-fix-links-2025-02-06
branch
from
7405889 to
f434ab9
Compare
|
All checks are green. Since this PR is for link fixes + some minor copyedits, I'm going to merge now with the approval we have. SIG feedback is still welcome. |
