Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [es] Create docs/contributing/asuntos.md #6088

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

didiViking
Copy link

Related issue: #5205

@didiViking didiViking requested a review from a team as a code owner January 27, 2025 15:44
@opentelemetrybot opentelemetrybot requested review from a team and krol3 and removed request for a team January 27, 2025 15:44
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Thanks for your contribution. See inline comments for guidance.

content/es/docs/contributing/asuntos.md Outdated Show resolved Hide resolved
default_lang_commit: 30783526402b69a3ac44eeb0f6cf066732f0bdca
default_lang_commit: 8256a7512f0f5e677963e082d257edc443940565
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By updating the commit hash you are confirming that no changes since 3078352 affect the content of this file. Is that true? (I don't think so.) If not, revert this change.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krol3 I'm a bit confused about this. According to "git log" commit "8256a7512f0f5e677963e082d257edc443940565" is the latest one relevant to this page as mentioned per doc: https://krolcloud.notion.site/OpenTelemetry-Traducci-n-10cfbe995e9480739979fa231be6f519.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krol3 I'm a bit confused about this. According to "git log" commit "8256a7512f0f5e677963e082d257edc443940565" is the latest one relevant to this page as mentioned per doc: https://krolcloud.notion.site/OpenTelemetry-Traducci-n-10cfbe995e9480739979fa231be6f519.

I will try to clarify, the official documentation is here https://opentelemetry.io/docs/contributing/localization/

Copy link
Author

@didiViking didiViking Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[@krol3] Thanks, I took a look and this is the last commit based on the docs:
8256a75.
Screenshot 2025-01-29 at 09 24 58

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krol3 Can this be marked as solved?

Copy link
Contributor

@chalin chalin Feb 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@didiViking, generally speaking, don't mark a thread as resolved if you didn't create the thread; unless it is very clear that the issue is resolved, which it isn't in this case.

To learn how to manage default_lang_commit fields, read Keeping track of localized-page drift. Let me know if you know if you have any questions after reading that.

In particular you should be using commands like the following to help you figure out the es page drift:

  • npm run check:i18n -- content/es/docs/contributing/_index.md
  • npm run check:i18n -- -d content/es/docs/contributing/_index.md to see the diff details.

I've marked this PR as blocked until the default_lang_commit updates are undone or properly addressed. Thanks.

@opentelemetrybot opentelemetrybot requested review from a team January 27, 2025 17:24
Copy link
Contributor

@krol3 krol3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@didiViking excelent work! thanks for your contribution

content/es/docs/contributing/issues.md Outdated Show resolved Hide resolved
content/es/docs/contributing/issues.md Outdated Show resolved Hide resolved
content/es/docs/contributing/issues.md Outdated Show resolved Hide resolved
content/es/docs/contributing/issues.md Outdated Show resolved Hide resolved
content/es/docs/contributing/issues.md Outdated Show resolved Hide resolved
content/es/docs/contributing/issues.md Outdated Show resolved Hide resolved
content/es/docs/contributing/issues.md Outdated Show resolved Hide resolved
content/es/docs/contributing/issues.md Outdated Show resolved Hide resolved
content/es/docs/contributing/issues.md Outdated Show resolved Hide resolved
content/es/docs/contributing/issues.md Outdated Show resolved Hide resolved
@opentelemetrybot opentelemetrybot requested review from a team and mx-psi and removed request for a team January 29, 2025 15:44
@didiViking didiViking requested a review from krol3 January 29, 2025 15:46
@opentelemetrybot opentelemetrybot requested a review from a team January 29, 2025 15:46
@chalin chalin added the blocked label Feb 2, 2025
@chalin
Copy link
Contributor

chalin commented Feb 2, 2025

@krol3 and @open-telemetry/docs-es-approvers - as mentioned in https://cloud-native.slack.com/archives/C076RUAGP37/p1738265105433829

All: a quick reminder to tag your PRs with the label docs-approval-missing when you have completed your locale-specific review and are awaiting final docs-maintainers approval.

Thanks.

Signed-off-by: Diana Todea <diane.todea@gmail.com>
Signed-off-by: Diana Todea <diane.todea@gmail.com>
Signed-off-by: Diana Todea <diane.todea@gmail.com>
Signed-off-by: Diana Todea <diane.todea@gmail.com>
Signed-off-by: Diana Todea <diane.todea@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants