-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [es] Create docs/contributing/asuntos.md #6088
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. Thanks for your contribution. See inline comments for guidance.
default_lang_commit: 30783526402b69a3ac44eeb0f6cf066732f0bdca | ||
default_lang_commit: 8256a7512f0f5e677963e082d257edc443940565 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By updating the commit hash you are confirming that no changes since 3078352 affect the content of this file. Is that true? (I don't think so.) If not, revert this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@krol3 I'm a bit confused about this. According to "git log" commit "8256a7512f0f5e677963e082d257edc443940565" is the latest one relevant to this page as mentioned per doc: https://krolcloud.notion.site/OpenTelemetry-Traducci-n-10cfbe995e9480739979fa231be6f519.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@krol3 I'm a bit confused about this. According to "git log" commit "8256a7512f0f5e677963e082d257edc443940565" is the latest one relevant to this page as mentioned per doc: https://krolcloud.notion.site/OpenTelemetry-Traducci-n-10cfbe995e9480739979fa231be6f519.
I will try to clarify, the official documentation is here https://opentelemetry.io/docs/contributing/localization/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@krol3 Can this be marked as solved?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@didiViking, generally speaking, don't mark a thread as resolved if you didn't create the thread; unless it is very clear that the issue is resolved, which it isn't in this case.
To learn how to manage default_lang_commit
fields, read Keeping track of localized-page drift. Let me know if you know if you have any questions after reading that.
In particular you should be using commands like the following to help you figure out the es
page drift:
npm run check:i18n -- content/es/docs/contributing/_index.md
npm run check:i18n -- -d content/es/docs/contributing/_index.md
to see the diff details.
I've marked this PR as blocked
until the default_lang_commit
updates are undone or properly addressed. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@didiViking excelent work! thanks for your contribution
@krol3 and @open-telemetry/docs-es-approvers - as mentioned in https://cloud-native.slack.com/archives/C076RUAGP37/p1738265105433829
Thanks. |
Signed-off-by: Diana Todea <diane.todea@gmail.com>
Signed-off-by: Diana Todea <diane.todea@gmail.com>
Signed-off-by: Diana Todea <diane.todea@gmail.com>
Signed-off-by: Diana Todea <diane.todea@gmail.com>
Signed-off-by: Diana Todea <diane.todea@gmail.com>
ac8ba46
to
c593266
Compare
Related issue: #5205