❇️ added slow frozen rendering instrumentation #496
Conversation
Archish27
requested review from
nachoBonafonte,
bryce-b and
vvydier
as code owners
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #496 +/- ##
==========================================
+ Coverage 66.43% 66.47% +0.04%
==========================================
Files 335 335
Lines 14301 14301
==========================================
+ Hits 9501 9507 +6
+ Misses 4800 4794 -6 ☔ View full report in Codecov by Sentry. |
|
Can you also add a simple test for this? |
|
|
||
| func reportFrame(_ type: String, _ activityName: String, _ count: Int) { | ||
| let now = Date() | ||
| let span = tracer.spanBuilder(spanName: type).setStartTime(time: now).startSpan() |
There was a problem hiding this comment.
I think it would be more appropriate to utilize an event rather than a span to collecting this data. What do you think?
|
Does this need adding to the Package.swift too? Looks like it's just loose in Instrumentation/ where others have distinct products. |
|
@Archish27 This is a good addition, but we have some feedback we'd like you to address. |
|
@Archish27 Any update on this ? |
|
Waiting for some movement and we will reopen. |
feature : #495