fixed removeContextValue and changed log body from String to Any #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vvydier
commented
Dec 18, 2023
vvydier
commented
- fixed removeContextValue
- Added a test case for removeContextValue. Is there a better way to test this?
- Changed log body from String to Any, changed the related code and tests
bryce-b
reviewed
Dec 19, 2023
| @@ -70,12 +70,11 @@ class ActivityContextManager: ContextManager { | |||
| func removeContextValue(forKey key: OpenTelemetryContextKeys, value: AnyObject) { | |||
| let activityIdent = os_activity_get_identifier(OS_ACTIVITY_CURRENT, nil) | |||
|
closing this and splitting this effort into 2 PR's as there are separate issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.