Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace dependencies #1457

Merged
merged 29 commits into from
Dec 30, 2023
Merged

Conversation

rodoufu
Copy link
Contributor

@rodoufu rodoufu commented Dec 27, 2023

Adds shared dependencies to the workspace.
It improves the experience while managing the dependencies.

Changes

Picked the shared dependencies of the member projects and used added then to the workspace dependencies, https://crates.io/crates/work_dep can help with that.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@rodoufu rodoufu marked this pull request as ready for review December 27, 2023 16:44
@rodoufu rodoufu requested a review from a team December 27, 2023 16:44
@rodoufu
Copy link
Contributor Author

rodoufu commented Dec 27, 2023

Adding the the workspace dependencies will make it easier to then fix this other one #1252 when tonic is updated to 0.10.0

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5aa0311) 60.8% compared to head (4387a84) 60.8%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1457   +/-   ##
=====================================
  Coverage   60.8%   60.8%           
=====================================
  Files        146     146           
  Lines      19230   19230           
=====================================
  Hits       11702   11702           
  Misses      7528    7528           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rodoufu rodoufu mentioned this pull request Dec 27, 2023
4 tasks
@lalitb
Copy link
Member

lalitb commented Dec 27, 2023

I like this approach - seems this will ensure the version consistency for dependencies across the crates, and (possibly) decrease the build time.

Copy link
Contributor

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generally prefer this approach, and have used it successfully in other projects.

Cargo.toml Show resolved Hide resolved
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on my Rust expertise. Good to have reviewed by @hdost / @TommyCpp too :)

Copy link
Contributor

@TommyCpp TommyCpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be a nice improvement. Thanks!

@TommyCpp TommyCpp merged commit f31c4dd into open-telemetry:main Dec 30, 2023
14 checks passed
@rodoufu rodoufu deleted the workspaceDependencies branch January 3, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants