-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workspace dependencies #1457
Workspace dependencies #1457
Conversation
Adding the the workspace dependencies will make it easier to then fix this other one #1252 when tonic is updated to 0.10.0 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1457 +/- ##
=====================================
Coverage 60.8% 60.8%
=====================================
Files 146 146
Lines 19230 19230
=====================================
Hits 11702 11702
Misses 7528 7528 ☔ View full report in Codecov by Sentry. |
I like this approach - seems this will ensure the version consistency for dependencies across the crates, and (possibly) decrease the build time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I generally prefer this approach, and have used it successfully in other projects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be a nice improvement. Thanks!
Adds shared dependencies to the workspace.
It improves the experience while managing the dependencies.
Changes
Picked the shared dependencies of the member projects and used added then to the workspace dependencies, https://crates.io/crates/work_dep can help with that.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes