Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch link checker to lychee #6972

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Switch link checker to lychee #6972

wants to merge 2 commits into from

Conversation

trask
Copy link
Member

@trask trask commented Dec 19, 2024

No description provided.

@codecov Codecov
Copy link

codecov bot commented Dec 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.09%. Comparing base (77b1f64) to head (db74959).

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #6972   +/-   ##
=========================================
  Coverage     90.09%   90.09%           
  Complexity     6600     6600           
=========================================
  Files           730      730           
  Lines         19843    19843           
  Branches       1955     1955           
=========================================
  Hits          17877    17877           
  Misses         1371     1371           
  Partials        595      595

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trask trask force-pushed the lychee branch 2 times, most recently from 2f9ab24 to e689b9c Compare December 19, 2024 03:17
@trask trask marked this pull request as ready for review December 19, 2024 03:20
@trask trask requested a review from a team as a code owner December 19, 2024 03:20
jkwatson
jkwatson approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. What is/was the motivation for the change?

@trask
Copy link
Member Author

trask commented Dec 19, 2024

it validates cross-file anchor links (open-telemetry/semantic-conventions#1009), and is faster and has better retry behavior (so we don't need to do external file-by-file retries anymore)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkwatson jkwatson jkwatson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trask @jkwatson