New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI failure: e2e databasesql json comparison failure #1403

Open

MrAlias opened this issue Dec 10, 2024 · 4 comments

Labels

bug

Milestone

Contributor

MrAlias commented Dec 10, 2024

https://github.com/open-telemetry/opentelemetry-go-instrumentation/actions/runs/12264978340/job/34220096648?pr=1401

This does not look to be too common.

MrAlias added the bug label

MrAlias added this to the v0.20.0-alpha milestone

Contributor Author

MrAlias commented Dec 10, 2024

Contributor

damemi commented Dec 11, 2024

looks like a race between the new test cases

opentelemetry-go-instrumentation/internal/test/e2e/databasesql/main.go

Lines 146 to 147 in b195375

    
           {url: "http://localhost:8080/insert"}, 
        
           {url: "http://localhost:8080/update"},

Contributor Author

MrAlias commented Dec 19, 2024

Another example: https://github.com/open-telemetry/opentelemetry-go-instrumentation/actions/runs/12416302031/job/34664710679?pr=1490

Contributor Author

MrAlias commented Dec 19, 2024

It think we should look into sorting the initial json_output function in addition to redeact_json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment