Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oteslog: Improve transforming slog.KindAny attributes #6254

Merged
merged 6 commits into from
Oct 16, 2024

Conversation

pellared
Copy link
Member

@pellared pellared commented Oct 15, 2024

Reuse convertValue in otelslog.

Follows #6237.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.1%. Comparing base (3074e86) to head (f990508).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #6254     +/-   ##
=======================================
+ Coverage   66.9%   67.1%   +0.2%     
=======================================
  Files        190     191      +1     
  Lines      12540   12621     +81     
=======================================
+ Hits        8395    8476     +81     
  Misses      3855    3855             
  Partials     290     290             
Files with missing lines Coverage Δ
bridges/otellogrus/hook.go 97.5% <ø> (ø)
bridges/otelslog/convert.go 100.0% <100.0%> (ø)
bridges/otelslog/handler.go 96.4% <100.0%> (-0.1%) ⬇️
bridges/otelzap/core.go 97.2% <ø> (ø)

@pellared pellared changed the title Otelslog-complex-attrs oteslog: Improve transforming slog.KindAny attributes Oct 15, 2024
@pellared pellared added enhancement New feature or request bridge: slog Related to the slog bridge labels Oct 15, 2024
@pellared pellared marked this pull request as ready for review October 15, 2024 08:57
@pellared pellared requested review from a team, dmathieu and MrAlias as code owners October 15, 2024 08:57
@pellared pellared merged commit e1389ca into open-telemetry:main Oct 16, 2024
25 checks passed
@pellared pellared deleted the otelslog-complex-attrs branch October 16, 2024 05:49
@pellared pellared added this to the v1.32.0 milestone Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bridge: slog Related to the slog bridge enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants