Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Run lint and test-race GitHub jobs on Windows #466

Merged

Conversation

scorpionknifes
Copy link
Member

@scorpionknifes scorpionknifes commented Dec 13, 2023

Resolves #450
Resloves #451

@scorpionknifes scorpionknifes requested review from a team and dmitryax December 13, 2023 14:00
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c1a2749) 63.78% compared to head (c7185f3) 63.78%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #466   +/-   ##
=======================================
  Coverage   63.78%   63.78%           
=======================================
  Files          39       39           
  Lines        2267     2267           
=======================================
  Hits         1446     1446           
  Misses        677      677           
  Partials      144      144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scorpionknifes scorpionknifes force-pushed the chore-add-windows-ci-tests-and-lint branch from 057ef9a to 6048726 Compare December 13, 2023 14:34
chloggen/internal/chlog/summary.go Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@scorpionknifes
Copy link
Member Author

Looks like multimod diff isn't working on Windows, always thought it was an issue with my local git

multimod diff -m tools -p 1.2.3
error running diff: VerifyWorkingTreeClean failed: working tree not clean

Related issue with go-git https://www.github.com/go-git/go-git/issues/691 👀

pellared
pellared previously approved these changes Dec 15, 2023
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@pellared pellared changed the title [chore] Run go tests on Windows GitHub runners CI [chore] Run go tests and golangci-lint in CI Dec 15, 2023
@pellared pellared dismissed their stale review December 15, 2023 08:40

test failure

@pellared
Copy link
Member

pellared commented Dec 15, 2023

I suggest adding something like

if runtime.GOOS == "windows" {
  t.Skip("diff does not work on Windows. Tracked under: https://github.com/open-telemetry/opentelemetry-go-build-tools/issues/467.")
}

to TestHasChanged unless you find a quick way to solve #467

pellared
pellared previously approved these changes Dec 15, 2023
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@pellared pellared dismissed their stale review December 20, 2023 07:42

comments pending

@pellared pellared changed the title [chore] Run go tests and golangci-lint in CI [chore] Run go tests and golangci-lint in CI on Windows Dec 20, 2023
@pellared pellared changed the title [chore] Run go tests and golangci-lint in CI on Windows [chore] Run lint and test-race GitHub jobs on Windows Dec 20, 2023
@pellared pellared merged commit 7a291b3 into open-telemetry:main Dec 28, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run go test on Windows
4 participants