[repo] Fix tests reliant on bugged sampling behavior #6097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol
…pentelemetry-dotnet into repo-sampling-fixes
rajkumar-rangaraj
approved these changes
Jan 26, 2025
Kielek
approved these changes
Jan 27, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6097 +/- ##
=======================================
Coverage 86.40% 86.40%
=======================================
Files 257 257
Lines 11649 11649
=======================================
Hits 10065 10065
Misses 1584 1584 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6093
Changes
ActivityListeners to clean up after themselvesDetails
There is a bug fix coming in .NET 10: dotnet/runtime#111289
It seems some of our tests are reliant on the bugged behavior. What this PR does is correct the test logic so it will work now and with the correct behavior coming in .NET 10.
Merge requirement checklist