Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[repo] move PooledList to Zipkin #6092

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[repo] move PooledList to Zipkin #6092

wants to merge 1 commit into from
+0 −2

Conversation

SimonCropp
Copy link
Contributor

Fixes #
Design discussion issue #

Changes

PooledList is only used in Zipkin. so move it there and remove the Share Compile Include complexity

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@SimonCropp SimonCropp requested a review from a team as a code owner January 23, 2025 05:33
@github-actions github-actions bot added pkg:OpenTelemetry.Exporter.Zipkin Issues related to OpenTelemetry.Exporter.Zipkin NuGet package pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package labels Jan 23, 2025
@Kielek Kielek changed the title move PooledList to Zipkin [repo] move PooledList to Zipkin Jan 23, 2025
Kielek
Kielek approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@Kielek Kielek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not against this change, as it is used only by this project.

CodeBlanch
CodeBlanch reviewed Jan 23, 2025
View reviewed changes
src/OpenTelemetry.Exporter.Zipkin/PooledList.cs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonCropp Would you please move this into the src\OpenTelemetry.Exporter.Zipkin\Implementation folder. IIRC in this project that's where all the internal stuff lives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodeBlanch CodeBlanch CodeBlanch left review comments

@Kielek Kielek Kielek approved these changes

Assignees
No one assigned
Labels
pkg:OpenTelemetry.Exporter.Zipkin Issues related to OpenTelemetry.Exporter.Zipkin NuGet package pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimonCropp @Kielek @CodeBlanch