[Exporter.Prometheus] remove redundant if in WriteUnicodeNoEscape #6077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pkg:OpenTelemetry.Exporter.Prometheus.HttpListener
Kielek
changed the title
Kielek
approved these changes
Jan 22, 2025
src/OpenTelemetry.Exporter.Prometheus.HttpListener/Internal/PrometheusSerializer.cs
Outdated
Show resolved
Hide resolved
…ometheusSerializer.cs Co-authored-by: Piotr Kiełkowicz <pkiekowicz@splunk.com>
CodeBlanch
reviewed
Jan 23, 2025
| @@ -102,16 +102,12 @@ public static int WriteUnicodeNoEscape(byte[] buffer, int cursor, ushort ordinal | |||
| buffer[cursor++] = unchecked((byte)(0b_1100_0000 | (ordinal >> 6))); | |||
| buffer[cursor++] = unchecked((byte)(0b_1000_0000 | (ordinal & 0b_0011_1111))); | |||
| } | |||
| else if (ordinal <= 0xFFFF) | |||
| else // all other <= 0xFFFF which is ushort.MaxValue | |||
There was a problem hiding this comment.
@SimonCropp Seems to be a style issue with how you dropped the comment. Sorry the rules in this repo are annoying strict 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Design discussion issue #
Changes
0x07FF is 2047
0xFFFF is 65535
Since there is
ordinal <= 0x07FFcheck before theordinal <= 0xFFFFthen theordinal <= 0xFFFFconfition is always trueMerge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes