Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs-logs] Use struct in the complex type logging demo #5577
[docs-logs] Use struct in the complex type logging demo #5577
Changes from 5 commits
ec9c1a2
fb82112
afa7488
0c91dc5
8339c95
e0dd65e
8eb96a7
3be7fb0
8d84c33
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 6 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-experimental / build-test (windows-latest, net8.0)
Check failure on line 6 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-experimental / build-test (windows-latest, net8.0)
Check failure on line 6 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-stable / build-test (windows-latest, net7.0)
Check failure on line 6 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-stable / build-test (windows-latest, net7.0)
Check failure on line 6 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-stable / build-test (windows-latest, net8.0)
Check failure on line 6 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-stable / build-test (windows-latest, net8.0)
Check failure on line 6 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-experimental / build-test (windows-latest, net7.0)
Check failure on line 6 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-experimental / build-test (windows-latest, net7.0)
Check failure on line 6 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-experimental / build-test (windows-latest, net6.0)
Check failure on line 6 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-experimental / build-test (windows-latest, net6.0)
Check failure on line 6 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-experimental / build-test (windows-latest, net6.0)
Check failure on line 6 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-experimental / build-test (windows-latest, net462)
Check failure on line 6 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-experimental / build-test (windows-latest, net462)
Check failure on line 6 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-stable / build-test (windows-latest, net462)
Check failure on line 6 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-stable / build-test (windows-latest, net462)
Check failure on line 6 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-stable / build-test (windows-latest, net6.0)
Check failure on line 6 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-stable / build-test (windows-latest, net6.0)
Check failure on line 8 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-experimental / build-test (windows-latest, net8.0)
Check failure on line 8 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-experimental / build-test (windows-latest, net8.0)
Check failure on line 8 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-stable / build-test (windows-latest, net7.0)
Check failure on line 8 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-stable / build-test (windows-latest, net7.0)
Check failure on line 8 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-stable / build-test (windows-latest, net8.0)
Check failure on line 8 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-stable / build-test (windows-latest, net8.0)
Check failure on line 8 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-experimental / build-test (windows-latest, net7.0)
Check failure on line 8 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-experimental / build-test (windows-latest, net7.0)
Check failure on line 8 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-experimental / build-test (windows-latest, net6.0)
Check failure on line 8 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-experimental / build-test (windows-latest, net6.0)
Check failure on line 8 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-experimental / build-test (windows-latest, net6.0)
Check failure on line 8 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-experimental / build-test (windows-latest, net462)
Check failure on line 8 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-experimental / build-test (windows-latest, net462)
Check failure on line 8 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-stable / build-test (windows-latest, net462)
Check failure on line 8 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-stable / build-test (windows-latest, net462)
Check failure on line 8 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-stable / build-test (windows-latest, net6.0)
Check failure on line 8 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-stable / build-test (windows-latest, net6.0)
Check failure on line 10 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-experimental / build-test (windows-latest, net8.0)
Check failure on line 10 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-experimental / build-test (windows-latest, net8.0)
Check failure on line 10 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-stable / build-test (windows-latest, net7.0)
Check failure on line 10 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-stable / build-test (windows-latest, net7.0)
Check failure on line 10 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-stable / build-test (windows-latest, net8.0)
Check failure on line 10 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-stable / build-test (windows-latest, net8.0)
Check failure on line 10 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-experimental / build-test (windows-latest, net7.0)
Check failure on line 10 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-experimental / build-test (windows-latest, net7.0)
Check failure on line 10 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-experimental / build-test (windows-latest, net6.0)
Check failure on line 10 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-experimental / build-test (windows-latest, net6.0)
Check failure on line 10 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-experimental / build-test (windows-latest, net6.0)
Check failure on line 10 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-experimental / build-test (windows-latest, net462)
Check failure on line 10 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-experimental / build-test (windows-latest, net462)
Check failure on line 10 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-stable / build-test (windows-latest, net462)
Check failure on line 10 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-stable / build-test (windows-latest, net462)
Check failure on line 10 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-stable / build-test (windows-latest, net6.0)
Check failure on line 10 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-stable / build-test (windows-latest, net6.0)
Check failure on line 12 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-experimental / build-test (windows-latest, net8.0)
Check failure on line 12 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-experimental / build-test (windows-latest, net8.0)
Check failure on line 12 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-stable / build-test (windows-latest, net7.0)
Check failure on line 12 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-stable / build-test (windows-latest, net7.0)
Check failure on line 12 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-stable / build-test (windows-latest, net8.0)
Check failure on line 12 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-stable / build-test (windows-latest, net8.0)
Check failure on line 12 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-experimental / build-test (windows-latest, net7.0)
Check failure on line 12 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-experimental / build-test (windows-latest, net7.0)
Check failure on line 12 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-experimental / build-test (windows-latest, net6.0)
Check failure on line 12 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-experimental / build-test (windows-latest, net462)
Check failure on line 12 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-experimental / build-test (windows-latest, net462)
Check failure on line 12 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-stable / build-test (windows-latest, net462)
Check failure on line 12 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-stable / build-test (windows-latest, net462)
Check failure on line 12 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-stable / build-test (windows-latest, net6.0)
Check failure on line 12 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-stable / build-test (windows-latest, net6.0)
Check failure on line 14 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-experimental / build-test (windows-latest, net8.0)
Check failure on line 14 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-experimental / build-test (windows-latest, net8.0)
Check failure on line 14 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-stable / build-test (windows-latest, net7.0)
Check failure on line 14 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-stable / build-test (windows-latest, net7.0)
Check failure on line 14 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-stable / build-test (windows-latest, net8.0)
Check failure on line 14 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-stable / build-test (windows-latest, net8.0)
Check failure on line 14 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-experimental / build-test (windows-latest, net7.0)
Check failure on line 14 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-experimental / build-test (windows-latest, net7.0)
Check failure on line 14 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-experimental / build-test (windows-latest, net462)
Check failure on line 14 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-experimental / build-test (windows-latest, net462)
Check failure on line 14 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-stable / build-test (windows-latest, net462)
Check failure on line 14 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-stable / build-test (windows-latest, net462)
Check failure on line 14 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-stable / build-test (windows-latest, net6.0)
Check failure on line 14 in docs/logs/complex-objects/FoodRecallNotice.cs
GitHub Actions / build-test-solution-stable / build-test (windows-latest, net6.0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in
with mutable structs can be tricky. If the compiler can't determine stuff isreadonly
it will make defensive copies. I think the auto-properties shown here are fine (IIRC the getters get marked asreadonly
automatically for auto-properties), but users could run into trouble if they handroll more. If we want to recommendin
we may also want to recommend thestruct
s bereadonly
too?readonly struct
+in
work always.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build failed, seems it is only available in .NET Core. I'll revert the change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would put the generated source under
.\obj\Debug\net8.0\generated\Microsoft.Gen.Logging\Microsoft.Gen.Logging.LoggingGenerator\Logging.g.cs
which helps to understand things behind the scene.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just FYI in case you weren't aware you can see them in IDE under the analyzer: