-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Instrumentation.Http] Move to contrib repository #5574
Merged
CodeBlanch
merged 11 commits into
open-telemetry:main
from
Kielek:migrate-http-instrumentation
Apr 29, 2024
Merged
[Instrumentation.Http] Move to contrib repository #5574
CodeBlanch
merged 11 commits into
open-telemetry:main
from
Kielek:migrate-http-instrumentation
Apr 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5574 +/- ##
==========================================
+ Coverage 83.38% 85.68% +2.30%
==========================================
Files 297 271 -26
Lines 12531 11376 -1155
==========================================
- Hits 10449 9748 -701
+ Misses 2082 1628 -454
Flags with carried forward coverage won't be shown. Click here to find out more.
|
It will again common when both packages are in contrib
Kielek
force-pushed
the
migrate-http-instrumentation
branch
from
April 26, 2024 08:54
f599af0
to
c41b03d
Compare
reyang
approved these changes
Apr 26, 2024
rajkumar-rangaraj
approved these changes
Apr 26, 2024
vishweshbankwar
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards: #5526
Related to: open-telemetry/opentelemetry-dotnet-contrib#1694
Changes
[Instrumentation.Http] Move to contrib repository
Merge requirement checklist
[ ] AppropriateCHANGELOG.md
files updated for non-trivial changes[ ] Changes in public API reviewed (if applicable)