Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Metrics code for Exemplars #5401

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Feb 28, 2024

Changes

  • Remove unnecessary isSampled parameter for Exemplars

Hide whitespaces from the diff for easier review of the code:

image

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.66%. Comparing base (6250307) to head (33e5e00).
Report is 105 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5401      +/-   ##
==========================================
+ Coverage   83.38%   84.66%   +1.27%     
==========================================
  Files         297      281      -16     
  Lines       12531    11457    -1074     
==========================================
- Hits        10449     9700     -749     
+ Misses       2082     1757     -325     
Flag Coverage Δ
unittests ?
unittests-Solution-Experimental 84.59% <100.00%> (?)
unittests-Solution-Stable 84.64% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/OpenTelemetry/Metrics/AggregatorStore.cs 82.48% <100.00%> (+2.09%) ⬆️
src/OpenTelemetry/Metrics/MetricPoint.cs 92.73% <100.00%> (+24.25%) ⬆️

... and 75 files with indirect coverage changes

@utpilla utpilla marked this pull request as ready for review February 28, 2024 23:18
@utpilla utpilla requested a review from a team February 28, 2024 23:18
@utpilla utpilla changed the title Refactors Metrics code for Exemplars Refactor Metrics code for Exemplars Feb 28, 2024
@utpilla
Copy link
Contributor Author

utpilla commented Feb 28, 2024

Check this comment: #5399 (comment)

@utpilla utpilla closed this Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant